Suggest 100 wei constant as tip in transactions #1561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-assign
bot
requested review from
ercecan,
eyusufatik,
jfldde,
kpp and
rakanalh
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
|
rakanalh
approved these changes
Dec 5, 2024
kpp
reviewed
Dec 5, 2024
| @@ -21,6 +21,7 @@ impl<C: sov_modules_api::Context> BlockCache<C> { | |||
| } | |||
|
|
|||
| /// Gets block from cache or from provider | |||
| #[allow(unused)] | |||
There was a problem hiding this comment.
It is not used, but I think it is too early to remove unused parts related to gas price oracle. We should keep them temporarily until we see that current suggestion mechanism works fine.
eyusufatik
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As a rollup, tips do not make much sense for us, as we will have congestions very rarely, and we already have dynamic basefee algorithm in place. After discussions with @eyusufatik , we decided to suggest 100 wei as tip always.
First we thought about returning 0, but then we would lose the ability to order EIP-1559 transactions completely since there won't be any chance to speed up in rare times of congestion. Hence, we settled on 100 wei, which should almost make no difference to price in regular times, but also should allow people to bump the tips by 10% in case of congestion.
Linked Issues
Testing
Describe how these changes were tested. If you've added new features, have you added unit tests?
Docs
Describe where this code is documented. If it changes a documented interface, have the docs been updated?