Date.UTC should return NaN for out-of-range time value #4615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to spec Section 20.3.3.4, if the time value is larger than ktvMax or smaller than ktvMin, then Date.UTC should return NaN rather than return the actual value. Also updated the link at L1645 to #1665: "Date.UTC(x) [single-argument case] semantics update".
|
/cc @dilijev @bterlson @obastemur Please review. Also should I target this to master, release/1.8 or release/1.9? |
xiaoyinl
changed the title
|
@xiaoyinl master is good. |
|
We're having issues with the commit signing service at the moment. When that is resolved I'll merge this. |
|
I see. Thanks for the review! |
|
@dotnet-bot test this please |
chakrabot
pushed a commit
that referenced
this pull request
Mar 16, 2018
…ime value Merge pull request #4615 from xiaoyinl:dateUTCoverflow According to spec [Section 20.3.3.4](https://tc39.github.io/ecma262/#sec-date.utc), if the time value is larger than `ktvMax` or smaller than `ktvMin`, then `Date.UTC` should return `NaN` rather than return the actual value. Also updated the link at L1645 to #1665: "Date.UTC(x) [single-argument case] semantics update". Test case: `Date.UTC(2001, 1, 5e+9)` ChakraCore: 432000980899200000 SpiderMonkey and v8: NaN
|
@xiaoyinl apologies for the delay in landing this. Thanks for your contribution! |
|
@dilijev No problem! Thanks for landing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to spec Section 20.3.3.4, if the time value is larger than
ktvMaxor smaller thanktvMin, thenDate.UTCshould returnNaNrather than return the actual value.Also updated the link at L1645 to #1665: "Date.UTC(x) [single-argument case] semantics update".
Test case:
Date.UTC(2001, 1, 5e+9)ChakraCore: 432000980899200000
SpiderMonkey and v8: NaN