Error improvements #6347
Merged
Error improvements #6347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zenparsing
reviewed
Dec 5, 2019
rhuanjl
force-pushed
the
parseErrorImprovements
branch
from
94b2756 to
f2aad9f
Compare
|
I wanted to sort out the ReferenceError/SyntaxError thing to get down to only one test262 fail for me Top Level Await implementation; and thought I may as well do a few more error fixes whilst I was at it. Anyway I've updated for feedback and rebased so hopefully good to merge. |
zenparsing
approved these changes
Dec 5, 2019
chakrabot
pushed a commit
that referenced
this pull request
Dec 6, 2019
Merge pull request #6347 from rhuanjl:parseErrorImprovements This PR turns early reference errors into syntax errors per tc39/ecma262#1527 And makes a few other error message improvements including fixing #6339 fix: #6339
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR turns early reference errors into syntax errors per tc39/ecma262#1527
And makes a few other error message improvements including fixing #6339
fix: #6339