Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

Commit

Permalink
fix(checkbox): improve production build for function slots
Browse files Browse the repository at this point in the history
  • Loading branch information
codebender828 committed Dec 11, 2022
1 parent 43bcb43 commit 1a78d56
Show file tree
Hide file tree
Showing 4 changed files with 59 additions and 4 deletions.
46 changes: 46 additions & 0 deletions .changeset/slow-tables-compare.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
---
"@chakra-ui/vue-anatomy": minor
"@chakra-ui/c-accordion": minor
"@chakra-ui/c-alert": minor
"@chakra-ui/c-avatar": minor
"@chakra-ui/c-breadcrumb": minor
"@chakra-ui/c-button": minor
"@chakra-ui/c-checkbox": minor
"@chakra-ui/c-close-button": minor
"@chakra-ui/c-code": minor
"@chakra-ui/c-color-mode": minor
"@chakra-ui/c-flex": minor
"@chakra-ui/c-focus-lock": minor
"@chakra-ui/c-form-control": minor
"@chakra-ui/c-icon": minor
"@chakra-ui/c-image": minor
"@chakra-ui/c-input": minor
"@chakra-ui/c-media-query": minor
"@chakra-ui/c-modal": minor
"@chakra-ui/c-motion": minor
"@chakra-ui/c-pin-input": minor
"@chakra-ui/c-popper": minor
"@chakra-ui/c-portal": minor
"@chakra-ui/c-reset": minor
"@chakra-ui/c-scroll-lock": minor
"@chakra-ui/c-skip-nav": minor
"@chakra-ui/c-spinner": minor
"@chakra-ui/c-tag": minor
"@chakra-ui/c-theme-provider": minor
"@chakra-ui/c-visually-hidden": minor
"@chakra-ui/vue-next": minor
"@chakra-ui/vue-layout": minor
"@chakra-ui/nuxt-next": minor
"@chakra-ui/vue-styled": minor
"@chakra-ui/vue-system": minor
"@chakra-ui/vue-test-utils": minor
"@chakra-ui/vue-theme": minor
"@chakra-ui/vue-theme-tools": minor
"@chakra-ui/vue-utils": minor
"@chakra-ui/vue-a11y": minor
"@chakra-ui/vue-composables": minor
"@chakra-ui/vue-auto-import": minor
"@chakra-ui/vue-docs": minor
---

Create Media Query, Avatar, Counter and Checkbox Components"
5 changes: 4 additions & 1 deletion components.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
*
* This is a generated file. Do not edit it's contents.
*
* This file was generated on 2022-10-06T19:08:38.068Z
* This file was generated on 2022-12-11T15:07:27.518Z
*/

import { ChakraProps, chakra } from "@chakra-ui/vue-system"
Expand Down Expand Up @@ -86,6 +86,8 @@ declare module "@vue/runtime-core" {
CFormLabel: typeof import("@chakra-ui/vue-next")["CFormLabel"]
CRequiredIndicator: typeof import("@chakra-ui/vue-next")["CRequiredIndicator"]
CIcon: typeof import("@chakra-ui/vue-next")["CIcon"]
CImage: typeof import("@chakra-ui/vue-next")["CImage"]
CImg: typeof import("@chakra-ui/vue-next")["CImg"]
CInput: typeof import("@chakra-ui/vue-next")["CInput"]
CInputAddon: typeof import("@chakra-ui/vue-next")["CInputAddon"]
CInputGroup: typeof import("@chakra-ui/vue-next")["CInputGroup"]
Expand Down Expand Up @@ -146,6 +148,7 @@ declare module "@vue/runtime-core" {
CCollapse: typeof import("@chakra-ui/vue-next")["CCollapse"]
CMotion: typeof import("@chakra-ui/vue-next")["CMotion"]
CPinInput: typeof import("@chakra-ui/vue-next")["CPinInput"]
CPinInputClearButton: typeof import("@chakra-ui/vue-next")["CPinInputClearButton"]
CPinInputField: typeof import("@chakra-ui/vue-next")["CPinInputField"]
CPortal: typeof import("@chakra-ui/vue-next")["CPortal"]
CSkipNavContent: typeof import("@chakra-ui/vue-next")["CSkipNavContent"]
Expand Down
2 changes: 1 addition & 1 deletion packages/c-checkbox/src/checkbox-icon.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ export const CheckboxIcon = defineComponent(

return () => (
<CCheckboxTransition open={props.isChecked || props.isIndeterminate}>
{() => <IconEl.value {...attrs} />}
<IconEl.value {...attrs} />
</CCheckboxTransition>
)
}
Expand Down
10 changes: 8 additions & 2 deletions packages/c-checkbox/src/checkbox.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,8 @@ const CCheckboxControl = chakra("span", {
},
})

console.log("CCheckboxControl", CCheckboxControl)

const CLabel = chakra("label", {
baseStyle: {
cursor: "pointer",
Expand Down Expand Up @@ -176,7 +178,9 @@ export const CCheckbox: ComponentWithProps<CCheckboxProps> = defineComponent({
},
emits: ["change", "update:modelValue"],
setup(props, { slots, attrs, emit }) {
const group = useCheckboxGroupContext(computed(() => ({} as unknown)))
const group = useCheckboxGroupContext(
computed(() => ({} as CheckboxGroupContext))
)
const ownProps = computed(() => omitThemingProps(props))
const mergedProps = computed(() => mergeWith({}, group.value, props, attrs))
const styles = useMultiStyleConfig("Checkbox", mergedProps)
Expand Down Expand Up @@ -314,6 +318,8 @@ export const CCheckbox: ComponentWithProps<CCheckboxProps> = defineComponent({
const children = getValidChildren(slots)
const hasChildren = children.length > 0

console.log("clonedIcon", clonedIcon)

return (
<chakra.div
sx={{
Expand All @@ -334,7 +340,7 @@ export const CCheckbox: ComponentWithProps<CCheckboxProps> = defineComponent({
__css={styles.value.control}
{...api.value.controlProps}
>
{clonedIcon.value}
{() => clonedIcon.value}
</CCheckboxControl>
{hasChildren && (
<chakra.span
Expand Down

0 comments on commit 1a78d56

Please sign in to comment.