Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

feat: modal component #44

Merged
merged 54 commits into from
Jun 16, 2021
Merged

feat: modal component #44

merged 54 commits into from
Jun 16, 2021

Conversation

codebender828
Copy link
Collaborator

@codebender828 codebender828 commented Mar 29, 2021

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes
    /start features)

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the new behavior?

  • Adds modal component
  • Adds documentation of the component guide

Does this introduce a breaking change?

  • Yes
  • No

Other information

Some known issues:

  • Focus lock loses final focus node during DOM patching. (Fixed by tracking focus selector within modal component)
  • Transitioning of Modal content component.
  • Documentation of Modal component.
  • Documentation of development guide for CModal.
  • aria-hidden composable loses track of dialog element.

@changeset-bot
Copy link

changeset-bot bot commented Mar 29, 2021

🦋 Changeset detected

Latest commit: 718bc68

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 27 packages
Name Type
@chakra-ui/c-accordion Minor
@chakra-ui/c-alert Minor
@chakra-ui/c-button Minor
@chakra-ui/c-code Minor
@chakra-ui/c-flex Minor
@chakra-ui/c-focus-lock Minor
@chakra-ui/c-icon Minor
@chakra-ui/c-modal Minor
@chakra-ui/c-motion Minor
@chakra-ui/c-popper Minor
@chakra-ui/c-portal Minor
@chakra-ui/c-reset Minor
@chakra-ui/c-scroll-lock Minor
@chakra-ui/c-spinner Major
@chakra-ui/c-visually-hidden Minor
@chakra-ui/vue-next Major
@chakra-ui/vue-layout Minor
@chakra-ui/vue-theme Minor
@chakra-ui/vue-theme-tools Minor
@chakra-ui/vue-utils Minor
@chakra-ui/vue-a11y Minor
@chakra-ui/vue-composables Minor
@chakra-ui/vue-auto-import Minor
@chakra-ui/vue-docs Minor
@chakra-ui/c-close-button Patch
@chakra-ui/c-theme-provider Major
@chakra-ui/vue-system Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Mar 29, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

chakra-ui-vue-next – ./

🔍 Inspect: https://vercel.com/chakra-ui/chakra-ui-vue-next/CvAeehiERXk4g4UMnjQaRBXH4SoY
✅ Preview: https://chakra-ui-vue-next-git-feat-modal-chakra-ui.vercel.app

[Deployment for 718bc68 canceled]

chakra-ui-vue-next-playground – ./

🔍 Inspect: https://vercel.com/chakra-ui/chakra-ui-vue-next-playground/CBHcaT69hgXHB5D9hk2R3o2LweVE
✅ Preview: https://chakra-ui-vue-next-playground-git-feat-modal-chakra-ui.vercel.app

CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@carwack carwack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🚀

I really like the docs part and some of the small improvements for DX. 👏

playground/src/App.vue Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – chakra-ui-vue-next-playground June 16, 2021 07:11 Inactive
@codebender828 codebender828 marked this pull request as ready for review June 16, 2021 07:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: work in progress 🐜 Someone is working on this type: feature or enhancement ⚡️ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants