Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

feat: c-code component #59

Merged
merged 4 commits into from
Apr 8, 2021
Merged

feat: c-code component #59

merged 4 commits into from
Apr 8, 2021

Conversation

devivekw
Copy link
Contributor

@devivekw devivekw commented Apr 7, 2021

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes
    /start features)

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the new behavior?

  • Introduced c-code component
  • Added c-code examples
  • Added c-code documentation

Does this introduce a breaking change?

  • Yes
  • No

Other information / questions

This is my first PR to the library, I like using the React library and I wanted to see the Vue library grow as well. I am looking forward to contributing more and more, this is just a start. 😃

  • I know there might be with my code, I hope you can excuse this and I will work on improving it as I move on.
  • I wasn't sure about the documentation props table, the Markdown preview on VSCode wasn't accurate about the table I am assuming the documentation website has its own parser for the tables. If not let me know and I can work on changing the documentation again.

@changeset-bot
Copy link

changeset-bot bot commented Apr 7, 2021

🦋 Changeset detected

Latest commit: 675a8a1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 25 packages
Name Type
@chakra-ui/c-accordion Patch
@chakra-ui/c-alert Patch
@chakra-ui/c-badge Patch
@chakra-ui/c-button Patch
@chakra-ui/c-close-button Patch
@chakra-ui/c-code Patch
@chakra-ui/c-color-mode Patch
@chakra-ui/c-flex Patch
@chakra-ui/c-icon Patch
@chakra-ui/c-modal Patch
@chakra-ui/c-popper Patch
@chakra-ui/c-portal Patch
@chakra-ui/c-reset Patch
@chakra-ui/c-spinner Patch
@chakra-ui/c-theme-provider Patch
@chakra-ui/c-visually-hidden Patch
@chakra-ui/vue-next Patch
@chakra-ui/nuxt-next Patch
@chakra-ui/vue-system Patch
@chakra-ui/vue-test-utils Patch
@chakra-ui/vue-theme Patch
@chakra-ui/vue-theme-tools Patch
@chakra-ui/vue-utils Patch
@chakra-ui/vue-auto-import Patch
@chakra-ui/vue-docs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Apr 7, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

chakra-ui-vue-next – ./

🔍 Inspect: https://vercel.com/chakra-ui/chakra-ui-vue-next/GAWcNnvzcX3tcCXTAKXL2Dq7YfR1
✅ Preview: https://chakra-ui-vue-next-git-fork-devivekw-feat-c-code-chakra-ui.vercel.app

chakra-ui-vue-next-playground – ./

🔍 Inspect: https://vercel.com/chakra-ui/chakra-ui-vue-next-playground/FzCJy5n2Yd9hDC6htCpd2antuvnA
✅ Preview: https://chakra-ui-vue-git-fork-devivekw-feat-c-code-ch-a93d8a.vercel.app

@devivekw
Copy link
Contributor Author

devivekw commented Apr 7, 2021

Hey @codebender828 I have created the PR again, thanks for helping me out!

Copy link
Collaborator

@codebender828 codebender828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work here, @devivekw ! Thank you for contributing 💖

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants