Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(svelte): use vite spa for dev mode and improve usemachine #560

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

Shyrro
Copy link
Contributor

@Shyrro Shyrro commented Mar 10, 2023

Add a brief description

Currently, we were able to make Svelte work with SSR thanks to many contributions. However, the "dev" mode of a SvelteKit app doesn't seem to be compatible with the monorepo. SvelteKit is not able to understand some workspace packages. ( The dev mode is the issue, as the "preview" command works perfectly )

Since the SSR issues are solved, let's convert the Svelte examples app to a Vite CSR SPA to be able to move on with Svelte.

Please describe the current behavior that you are modifying

From SvelteKit app to Vite SPA app.

This also improves a little bit the useMachine hook for Svelte to make it start and stop at the right moment, but also unsubscribe from the state machine at the right moment.

💣 Is this a breaking change (Yes/No):

No

📝 Additional Information

Once this is merged we can open the "Try svelte" PR not as Draft anymore.

@changeset-bot
Copy link

changeset-bot bot commented Mar 10, 2023

⚠️ No Changeset found

Latest commit: 2752109

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package "svelte-ts" depends on the ignored package "@zag-js/shared", but "svelte-ts" is not being ignored. Please add "svelte-ts" to the `ignore` option.

@vercel
Copy link

vercel bot commented Mar 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
zag-nextjs ✅ Ready (Inspect) Visit Preview Mar 10, 2023 at 3:15PM (UTC)
zag-solid ✅ Ready (Inspect) Visit Preview Mar 10, 2023 at 3:15PM (UTC)
zag-vue ✅ Ready (Inspect) Visit Preview Mar 10, 2023 at 3:15PM (UTC)

@Shyrro Shyrro changed the title feat(svelte): use vite spa and improve usemachine feat(svelte): use vite spa for dev mode and improve usemachine Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants