Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for unicode surrogate pairs #11

Closed
sindresorhus opened this issue Mar 11, 2016 · 4 comments · Fixed by #20
Closed

Support for unicode surrogate pairs #11

sindresorhus opened this issue Mar 11, 2016 · 4 comments · Fixed by #20
Labels
enhancement help wanted

Comments

@sindresorhus
Copy link
Member

https://mathiasbynens.be/notes/javascript-unicode

I've added a failing skipped test: 970e1a7
This was referenced Mar 11, 2016
Closed
Closed
@kevva
Copy link
Contributor

kevva commented Jul 1, 2017

Would it be okay if I rewrote it to using ES2015 syntax? This is so we can iterate through them like https://github.com/chalk/slice-ansi/pull/8/files#diff-168726dbe96b3ce427e7fedce31bb0bcR50. Without for...of we'd need to introduce some looping logic that does this for us.

@sindresorhus
Copy link
Member Author

Sure

@sindresorhus
Copy link
Member Author

@kevva This module is now using ES2015 syntax, although I might have missed something. Interested in resolving this issue here too?

@kevva
Copy link
Contributor

kevva commented Jul 21, 2017

Oh, nice that you beat me to it :). I'll take a look at it tonight!

kevva added a commit to kevva/wrap-ansi that referenced this issue Jul 21, 2017
@kevva
Add support for surrogate pairs and full width characters
0feb955 
Fixes chalk#10 and chalk#11.
@kevva kevva mentioned this issue Jul 21, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for surrogate pairs and full width characters kevva/wrap-ansi
2 participants
@sindresorhus @kevva