Add throttle metrics to describeTableConsumedCapacityAsync #29
Conversation
tylfin
force-pushed
the
throttleMetric
branch
from
83c00f0 to
feef572
Compare
|
Hey thanks this looks like a great addition! Im working hard on another project at the moment but once i get some free time ill look to merge it. |
Add ThrottleEventsDescription type Add async getThrottledEventsAsync Add ThrottledEvents to TableConsumedCapacityDescription type
tylfin
force-pushed
the
throttleMetric
branch
from
feef572 to
e025d1d
Compare
|
👍 love to see this get merged |
|
Any update on this? |
… getting applied the throttledWrite value
|
Sorry about the wait, merged now. I did find a few flow type errors and a bug where writes were getting applied to reads. @tylfin could you review my changes. |
|
Looks great, thanks @tmitchel2 |
|
So, now this is in, is there anything I need to add to my provisioner to use it? |
|
@schodemeiss This PR just makes the throttledReads/Writes available. You need to determine in your config when to scale (best place is here https://github.com/channl/dynamodb-lambda-autoscale/blob/master/src/Provisioner.js#L34). When you're running into massive throttles and need to scale, it usually means you have a hot-key issue. These issues tend to get worse over time if you're not pruning, so ensure you have the correct DynamoDB schema architecture before throwing money at the problem. |
From Amazon: "It is possible to have short spikes in consumed [READ/WRITE] capacity which do not show up [because] it is an average. So be careful when adjusting table [READ/WRITE] capacity to pay attention to the Throttled [READ/WRITE] Requests..."
Had a use-case for this type of functionality in my production system. Figured it would be useful for others and wanted to give back. Thanks for the awesome package!