-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify histogram thresholds in fixed-length array #1086
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@liaprins-czi are you sure that you have the branch version installed correctly? This is what I see: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed for me now! (I must have had mweiden-fix-issue-1042
earlier checked out instead of 1082).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks Matt!
Fixes #1082 For background, see the following: * d3/d3-array#46 * https://stackoverflow.com/questions/15880058/d3-js-ticks-function-giving-more-elements-than-needed
677995b
to
90ed9ed
Compare
Fixes #1082
📊
![Screen Shot 2020-01-02 at 3 53 13 PM]()
For background, see the following: