IDSEQ-1178 - Stronger validation for input filenames #2538
Conversation
| @@ -129,6 +129,12 @@ class LocalSampleFileUpload extends React.Component { | |||
| Paired files must be labeled with "_R1" or | |||
| "_R2" at the end of the basename. | |||
| </li> | |||
| <li> | |||
| File names must be no longer than 120 characters and can only | |||
| contain letters from English alphabet (A-Z, upper and lower | |||
There was a problem hiding this comment.
super nit: *the English alphabet ? (and below)
| @@ -129,6 +129,12 @@ class LocalSampleFileUpload extends React.Component { | |||
| Paired files must be labeled with "_R1" or | |||
| "_R2" at the end of the basename. | |||
| </li> | |||
| <li> | |||
| File names must be no longer than 120 characters and can only | |||
There was a problem hiding this comment.
Can you make this text a constant for reuse?
There was a problem hiding this comment.
You mean, the entire text or just this new sentence? Because it seems there are other lines that can be reused as well.
Do you think this is a blocker for this PR or is it a sanitization task that we should consider a specific PR dedicated to remove such redundancies?
There was a problem hiding this comment.
I would prefer to do it since it is a new sentence. It is not the problem of redundancy but keeping it in sync.
I see your point but I prefer to start doing it and set an example than keep following a bad pattern.
There was a problem hiding this comment.
Considering this is not only about this sentence, but the entire block of instructions (the previous 2 <li> items are exactly the same), would it make sense to create a new react component with these instructions instead of using a constant?
There was a problem hiding this comment.
@tfrcarvalho Do we have any pre-existing pattern that I should follow in this case?
There was a problem hiding this comment.
Ok, you got me convinced. Let's just make a low priority jira task to just consolidate this
| case), numbers (0-9), periods (.), hyphens (-) and underscores | ||
| (_). Spaces are not allowed. | ||
| </li> | ||
| <li>File names must be no longer than 140 characters.</li> |
There was a problem hiding this comment.
This line is not included above? Any particular reason?
There was a problem hiding this comment.
No, actually that line should have been removed, since the previous item already includes it. Thank you for pointing it out.
That's a good point. I created a new ticket for that: IDSEQ-1330 |
[IDSEQ-1643] Fix bug for cross-region S3 uploads### Description - This is just to address the cross-region copying issue from last week. See JIRA for details. - Using the S3 "global" non-regional specific endpoint means that AWS will resolve the region itself. ### Notes - This was the most elegant solution I could find. My original proposal was to use `GetBucketLocation` but apparently it is only for the bucket owner (https://docs.aws.amazon.com/AmazonS3/latest/API/API_GetBucketLocation.html). I also found suggestions to use head bucket but got 301 redirects / couldn't figure out how to get the region info from that (aws/aws-sdk-ruby#796). - This was the only use of S3_CLIENT that I found necessary to change, and it was the only one changed in the previous PR (#2538). - Why not set this global endpoint all the time? AWS recommends against it "Please configure the proper region to avoid multiple unnecessary redirects and signing attempts". And for most other requests we're in our own buckets in our known region. ### Tests - Testing with the reported user URL. #### Before:  #### After:  #### Ran samples end-to-end locally and it works: <img width="1088" alt="Screen Shot 2019-10-30 at 12 53 59 PM" src="https://user-images.githubusercontent.com/5652739/67895228-54f9fe00-fb17-11e9-9d5b-69c19cbcf898.png">
Description
Add stronger validation for input file names.
File names must be no longer than 120 characters and can only contain letters from English alphabet (A-Z, upper and lower case), numbers (0-9), periods (.), hyphens (-) and underscores (_). Spaces are not allowed.
I'm also replacing a few aws cli commands by their AWS ruby SDK counterparts.
Tests