-
Notifications
You must be signed in to change notification settings - Fork 0
Porting over Devin's auto snapshots work #8
Conversation
Not sure why it's complaining about ChildNode which already comes with Typescript...
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🤘
const stories = getStoriesFromStoryFileExports(storyFileExports); | ||
|
||
for (const [storyName, story] of Object.entries<StoryData>(stories)) { | ||
if (story.parameters?.snapshot?.disabled) continue; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not necessary now (especially since this is a port from Along), but at some point we should skip disabled tests, so that test runs display how many were skipped.
const testFn = story.parameters?.snapshot?.disabled ? test.skip : test;
testFn(`${storyName} is cool`, () => {
// ...
});
We used to do something similar in axe-storybook-testing: https://github.com/chanzuckerberg/axe-storybook-testing/blob/894e39a5bf4f96c791d5aefa486d9ff568002ec6/src/Suite.ts#L31
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤘
Thanks @ahuth! Could you publish 🙏 |
Will do, @lesliecodes! I'm going to make another change today, and then will publish. (Unless you need it on NPM ASAP) |
Nope, it can wait. :) Thanks! |
Published in v1.2.0 |
Renamed anthology to be consistent with the current naming.
Added a test so we can see it working