Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allows business tests to be run by both persistence mock and persistence instance #3700

Merged

Conversation

nayib-jose-gloria
Copy link
Contributor

@nayib-jose-gloria nayib-jose-gloria commented Dec 8, 2022

Signed-off-by: nayib-jose-gloria [email protected]

Changes

  • updated persistence mock to fit latest persistence implementation details, especially distinction between CollectionVersionWithDatasets and CollectionVersion models.
  • minor updates to business layer (i.e. validate for DatasetArtifactType against enum values instead of hardcoded list)
  • minor updates to test business layer to fit persistence updates

QA steps (optional)

  • Ran business tests locally against persistence mock and postgres docker containerized db instance

Notes for Reviewer

  • TODO: Update persistence interface to match updates to persistence/persistence mock during implementation phase
  • TODO: Better configure DB Session object to switch between db URIs

…an integration test with postgres docker container

Signed-off-by: nayib-jose-gloria <[email protected]>
Signed-off-by: nayib-jose-gloria <[email protected]>
Signed-off-by: nayib-jose-gloria <[email protected]>
@nayib-jose-gloria nayib-jose-gloria merged commit c9efaab into ebezzi/business-layer-unit-tests Dec 8, 2022
@nayib-jose-gloria nayib-jose-gloria deleted the nayib/fix-business-tests branch December 8, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants