feat(wmg): Filter Analytics #5106
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5106 +/- ##
==========================================
+ Coverage 86.73% 86.84% +0.10%
==========================================
Files 186 189 +3
Lines 13965 14280 +315
==========================================
+ Hits 12113 12401 +288
- Misses 1852 1879 +27
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@ashin-czi is this ready for review or still a draft 😄 ? Thank you! |
Still working on this! Got sidetracked for some cell cards stuff but back to it now, might need to pick your brain for this ticket at some point though! |
| @@ -156,6 +154,8 @@ export const loadStateFromQueryParams = ( | |||
| }) | |||
| ); | |||
|
|
|||
| removeParams(paramsToRemove); | |||
There was a problem hiding this comment.
removing params at the end of function
| [key: string]: string[]; | ||
| }>({}); | ||
|
|
||
| const filterIsSelected = useMemo(() => { |
There was a problem hiding this comment.
boolean if any filter is selected
| return false; | ||
| }, [currentOptions]); | ||
|
|
||
| const [filterBeforeAfterEventSent, setFilterBeforeAfterEventSent] = |
There was a problem hiding this comment.
used to make sure before and after events aren't being sent together
|
@ashin-czi just wanted to check the status on this PR given that it hasn't seen any movement for a few weeks. Thanks! |
|
#4534 (comment) closing for now |
Reason for Change
Changes
Testing steps
Notes for Reviewer