Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initial schema, migration framework, and orm setup #55

Merged
merged 4 commits into from
Feb 7, 2020
Merged

initial schema, migration framework, and orm setup #55

merged 4 commits into from
Feb 7, 2020

Conversation

parthshahva
Copy link
Contributor

No description provided.

@parthshahva parthshahva changed the title [WIP] initial schema setup initial schema, migration framework, and orm setup Feb 6, 2020
@parthshahva parthshahva mentioned this pull request Feb 6, 2020
Closed
4 tasks
maniarathi
maniarathi approved these changes Feb 7, 2020
View reviewed changes
Copy link
Contributor

@maniarathi maniarathi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one comment about using only ontologies. I couldn't find any obvious discrepancies in the table creations/foreign keys so well done.

dcp_prototype/backend/ledger/schema/versions/407ab1d9843a_initial_table_setup.py Outdated
Column("category", String, nullable=True),
Column("organ_ontology", String, nullable=True),
Column("developmental_stage", String, nullable=True),
Column("disease_ontology_label", String, nullable=True),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm using ontologies only through. Maybe let's stick with _ontology throughout for now, since ontology_label can be derived.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@parthshahva parthshahva merged commit 119d9b8 into master Feb 7, 2020
@parthshahva parthshahva deleted the schema-setup branch February 7, 2020 02:48
Bento007 pushed a commit that referenced this pull request Feb 13, 2020
@parthshahva @Bento007
initial schema, migration framework, and orm setup (#55)
a5a5add 
* initial schema and orm setup

* fix readme and linting

* linting fix

* fix ontology_label to ontology
Bento007 pushed a commit that referenced this pull request Feb 13, 2020
@parthshahva @Bento007
initial schema, migration framework, and orm setup (#55)
196df42 
* initial schema and orm setup

* fix readme and linting

* linting fix

* fix ontology_label to ontology
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maniarathi maniarathi maniarathi approved these changes

@mckinsel mckinsel Awaiting requested review from mckinsel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@parthshahva @maniarathi