Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thuang-download-feedback #613

Merged
merged 1 commit into from
Sep 16, 2020
Merged

Conversation

tihuan
Copy link
Contributor

@tihuan tihuan commented Sep 16, 2020

Tiny updates:

  1. Add a space between "please let us know at" and "[email protected]"
  2. Add max-width to name column, otherwise it could take up more space than intended (I missed that 😆 )
  3. Change "More Information" column to stack links vertically

For #3, I don't know if that's the best solution, so would love input from @pdugan20 🙏 One thing I was debating with myself is whether we could sort the link by text length, so at least shorter ones are on top and can take a tiny pyramid 🔺 But also unsure if the info links are already sorted by importance? CC: @maniarathi @mckinsel

Thanks all!

BEFORE:
Screen Shot 2020-09-16 at 10 38 02 AM

AFTER:
Screen Shot 2020-09-16 at 10 34 12 AM

@tihuan tihuan requested review from Bento007 and pdugan20 September 16, 2020 17:40
@maniarathi
Copy link
Contributor

I don't think the links are sorted in any particular order nor do we have that sorting in our database, so doesn't matter much there. At some point, we could order by type but I don't think it matters much (imo).

Copy link
Contributor

@pdugan20 pdugan20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think the ideal scenario for the list of links would be to all have them left justified and starting from the same position, and to comma separate them. But honestly the visuals in the attached screenshot look good to me so not worth going back to make changes!

@tihuan
Copy link
Contributor Author

tihuan commented Sep 16, 2020

Thanks @pdugan20 ! Yeah I was playing with that idea a little, but wasn't super successful lol But at least I added the comma back in the meantime!

Screen Shot 2020-09-16 at 12 40 05 PM

Also currently when resizing the screen, it doesn't look as good, because we haven't defined responsive design for different screen sizes. Do you see a need to prioritize that?

Thank you!

gif

@tihuan tihuan force-pushed the thuang-download-feedback branch from 2331ad8 to ba54338 Compare September 16, 2020 19:51
@tihuan
Copy link
Contributor Author

tihuan commented Sep 16, 2020

Sync'd with Pat offline! Since this is a temp page, the work above is good enough and we'll have more robust handling for the permanent pages! Mergingg

@tihuan tihuan merged commit 04f529f into tsmith/donwload_buttons Sep 16, 2020
@tihuan tihuan deleted the thuang-download-feedback branch September 16, 2020 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants