dashboard: support token #1188
Merged
dashboard: support token #1188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xiang <[email protected]>
Signed-off-by: xiang <[email protected]>
Signed-off-by: xiang <[email protected]>
Signed-off-by: xiang <[email protected]>
Signed-off-by: xiang <[email protected]>
Signed-off-by: xiang <[email protected]>
Signed-off-by: xiang <[email protected]>
Signed-off-by: xiang <[email protected]>
Signed-off-by: xiang <[email protected]>
Signed-off-by: wanyoulc <[email protected]>
Signed-off-by: xiang <[email protected]>
Signed-off-by: xiang <[email protected]>
Signed-off-by: xiang <[email protected]>
Signed-off-by: xiang <[email protected]>
Signed-off-by: xiang <[email protected]>
This reverts commit d54de84.
Signed-off-by: xiang <[email protected]>
Signed-off-by: xiang <[email protected]>
Signed-off-by: xiang <[email protected]>
Signed-off-by: wanyoulc <[email protected]>
Signed-off-by: xiang <[email protected]>
Signed-off-by: xiang <[email protected]>
Signed-off-by: wanyoulc <[email protected]>
Signed-off-by: wanyoulc <[email protected]>
Signed-off-by: wanyoulc <[email protected]>
Signed-off-by: wanyoulc <[email protected]>
* fix: experiment status Signed-off-by: Yue Yang <[email protected]> * chore: use in.Status directly Signed-off-by: Yue Yang <[email protected]> * chore: address comments Signed-off-by: Yue Yang <[email protected]> Co-authored-by: ti-srebot <[email protected]>
Signed-off-by: Yue Yang <[email protected]>
Signed-off-by: xiang <[email protected]>
|
@STRRL all comment addressed, PTAL again |
|
It looks like you need to deal with the conflict. |
Signed-off-by: xiang <[email protected]>
conflict resolved, PTAL again @fewdan |
Signed-off-by: xiang <[email protected]>
Signed-off-by: xiang <[email protected]>
STRRL
reviewed
Dec 4, 2020
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
@WangXiangUSTC merge failed. |
STRRL
pushed a commit
to STRRL/chaos-mesh
that referenced
this pull request
Dec 15, 2020
Signed-off-by: xiang <[email protected]> Signed-off-by: wanyoulc <[email protected]> Signed-off-by: Yue Yang <[email protected]> Signed-off-by: STRRL <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
RFC: https://github.com/chaos-mesh/rfcs/blob/main/text/2020-10-22-authn-and-authz-on-chaos-dashboard.md
Resolve #1092
Chaos can be created and deleted by anyone who has access to the dashboard, and the authority of the dashboard is very high, which means the Dashboard is a big security hazard.
The dashboard should use the k8s client with a token to visit the k8s cluster, and the token is provided by the user in the dashboard frontend. Users can only do chaos which is allowed by the token generated by the service account.
What is changed and how does it work?
Checklist
Tests
Side effects
Related changes
Does this PR introduce a user-facing change?