Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error keys processing and unset ns selectors #1323

Merged
merged 2 commits into from
Dec 25, 2020

Conversation

g1eny0ung
Copy link
Member

Signed-off-by: Yue Yang [email protected]

What problem does this PR solve?

Resolve #1318.

What is changed and how does it work?

Checklist

Tests

  • Unit test
  • E2E test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Breaking backward compatibility

Related changes

  • Need to update the documentation

Does this PR introduce a user-facing change?

NONE

@g1eny0ung g1eny0ung requested a review from cwen0 December 22, 2020 09:41
@cwen0 cwen0 added component/dashboard type/bug-fix Fix for a previously reported bug. labels Dec 23, 2020
Copy link
Member

@fewdan fewdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WangXiangUSTC
Copy link
Contributor

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@g1eny0ung merge failed.

@g1eny0ung
Copy link
Member Author

/run-all-tests

2 similar comments
@g1eny0ung
Copy link
Member Author

/run-all-tests

@STRRL
Copy link
Member

STRRL commented Dec 25, 2020

/run-all-tests

@g1eny0ung g1eny0ung merged commit 8806c02 into chaos-mesh:master Dec 25, 2020
@g1eny0ung g1eny0ung deleted the fix/1318 branch December 25, 2020 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't reuse the archived experiment by Chaos Dashboard
6 participants