Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[update] add httpchaos in install.sh #896

Merged
merged 4 commits into from
Sep 11, 2020
Merged

[update] add httpchaos in install.sh #896

merged 4 commits into from
Sep 11, 2020

Conversation

fewdan
Copy link
Member

@fewdan fewdan commented Sep 11, 2020

Signed-off-by: “fewdan” [email protected]

What problem does this PR solve?

add httpchaos in install.sh

What is changed and how does it work?

add httpchaos in install.sh

Checklist

Tests

  • Unit test
  • E2E test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Breaking backward compatibility

Related changes

  • Need to update the documentation

Does this PR introduce a user-facing change?

NONE

@fewdan
update
1662fc4 
Signed-off-by: “fewdan” <[email protected]>
@fewdan
update
cee7abf 
Signed-off-by: “fewdan” <[email protected]>
@fewdan
update
6a9aaa8 
Signed-off-by: “fewdan” <[email protected]>
@fewdan
update
d7a416e 
Signed-off-by: “fewdan” <[email protected]>
YangKeao
YangKeao approved these changes Sep 11, 2020
View reviewed changes
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could add a check for install.sh in CI later.

cwen0
cwen0 approved these changes Sep 11, 2020
View reviewed changes
Copy link
Member

@cwen0 cwen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwen0 cwen0 merged commit 1bb5679 into chaos-mesh:master Sep 11, 2020
@fewdan fewdan deleted the testyihaofu branch September 11, 2020 09:19
@cwen0 cwen0 mentioned this pull request Sep 16, 2020
Merged
@ti-srebot ti-srebot mentioned this pull request Sep 16, 2020
Merged
sjwsl pushed a commit to sjwsl/chaos-mesh that referenced this pull request May 6, 2021
@fewdan
[update] add httpchaos in install.sh (chaos-mesh#896)
678e98f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YangKeao YangKeao YangKeao approved these changes

@cwen0 cwen0 cwen0 approved these changes

@ti-srebot ti-srebot ti-srebot approved these changes

Assignees
No one assigned
Labels
status/LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fewdan @YangKeao @cwen0 @ti-srebot