Skip to content

Commit

Permalink
testsuite: drop fcntl locking test
Browse files Browse the repository at this point in the history
Problem: the threadrwlock unit tests is probing documented
fcntl locking behavior, but diod doesn't use it.

Diod locking is currently based on flock rather than fcntl locks,
because fcntl locks are per process not per fd, and diod uses a
thread pool within the same process to service requests.

Having this test isn't relaly helpful.  Drop it.
  • Loading branch information
garlick committed Jan 17, 2025
1 parent 7cacf63 commit c24c22f
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 209 deletions.
4 changes: 0 additions & 4 deletions src/libdiod/Makefile.am
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ test_ldadd = \

TESTS = \
test_configfile.t \
test_threadwrlock.t \
test_read.t \
test_directory.t \
test_lock.t \
Expand All @@ -61,9 +60,6 @@ T_LOG_DRIVER = env AM_TAP_AWK='$(AWK)' $(SHELL) \
test_configfile_t_SOURCES = test/configfile.c
test_configfile_t_LDADD = $(test_ldadd)

test_threadwrlock_t_SOURCES = test/threadwrlock.c
test_threadwrlock_t_LDADD = $(test_ldadd)

test_read_t_SOURCES = test/read.c
test_read_t_LDADD = $(test_ldadd)

Expand Down
205 changes: 0 additions & 205 deletions src/libdiod/test/threadwrlock.c

This file was deleted.

0 comments on commit c24c22f

Please sign in to comment.