Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[graal] Add support of Graal's CoCom Backend to ELK #651

Closed
wants to merge 1 commit into from

Conversation

inishchith
Copy link
Contributor

@inishchith inishchith commented Jun 30, 2019

Address: inishchith/gsoc#8

TODO:

  • Add tests
  • Update docstrings
  • Update commit description

NOTE:

  • The failing test is due to Graal module not being a part of requirements.txt(dependencies) and is a part of this PR just to check the coverage of new additions.

Signed-off-by: inishchith [email protected]

@valeriocos
Copy link
Member

As discussed at: inishchith/gsoc#11 (comment), please find below a proposal to extract modules from a file_path. The method extract_modules could be called in the get_rich_item, and the output stored in the attribute modules (or any other one) as follows: eitem['modules'] = self.extract_modules(file_path)

def extract_modules(file_path):

    path_chunks = file_path.split('/')

    modules = []
    for idx, p in enumerate(path_chunks):
        sub_path = '/'.join(path_chunks[:idx])

        if sub_path:
            modules.append(sub_path)

    return modules

WDYT @inishchith ?

@inishchith
Copy link
Contributor Author

@valeriocos Thanks for elaborating on the idea.
I'll update the PR and start working on the module-level idea.

Thanks!

@coveralls
Copy link

coveralls commented Jul 2, 2019

Pull Request Test Coverage Report for Build 1521

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 52 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 68.543%

Files with Coverage Reduction New Missed Lines %
/home/travis/build/chaoss/grimoirelab-elk/grimoire_elk/utils.py 52 60.56%
Totals Coverage Status
Change from base Build 1510: 0.2%
Covered Lines: 5722
Relevant Lines: 8348

💛 - Coveralls

@inishchith inishchith force-pushed the gsoc-graal-2019-cocom branch from e35eff2 to 66ec533 Compare July 2, 2019 13:35
@inishchith
Copy link
Contributor Author

@valeriocos i've added some tests.
I'm not sure why the coveralls task reports aren't displayed. Can you please have a look?

Add support of Graal's CoCom backend to ELK and it's corresponding tests

Signed-off-by: inishchith <[email protected]>
@inishchith inishchith force-pushed the gsoc-graal-2019-cocom branch from 66ec533 to 33b8761 Compare July 2, 2019 15:48
@inishchith inishchith changed the title [graal] Add support of Graal's CoCom Backend to ELK (WIP) [graal] Add support of Graal's CoCom Backend to ELK Jul 19, 2019
@inishchith
Copy link
Contributor Author

closing in reference to #664

@inishchith inishchith closed this Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants