Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[colic] Add copyright flag for extraction of copyright information #50

Merged
merged 2 commits into from
Aug 9, 2019
Merged

[colic] Add copyright flag for extraction of copyright information #50

merged 2 commits into from
Aug 9, 2019

Conversation

inishchith
Copy link
Contributor

@inishchith inishchith marked this pull request as ready for review August 8, 2019 04:53
@valeriocos valeriocos self-requested a review August 9, 2019 08:43
valeriocos
valeriocos reviewed Aug 9, 2019
View reviewed changes
Copy link
Member

@valeriocos valeriocos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @inishchith for the PR. Overall it looks good. I'm not sure whether copyright information should be included in the colic backend, since the latter is focused only on extracting licenses. WDYT?

@inishchith
Copy link
Contributor Author

@valeriocos Agree with you.
Thought behind the addition was that scancode_cli analyzer already provides information related to copyright and we've used it primarily to create visualizations. We could keep other analyzers consistent without affecting the visualizations.
In such a case, we need to update the CoLic Backend information under documentation.
Let me know what you think :)

@valeriocos valeriocos self-requested a review August 9, 2019 10:27
valeriocos
valeriocos approved these changes Aug 9, 2019
View reviewed changes
Copy link
Member

@valeriocos valeriocos left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @inishchith, LGTM
Updating the doc is perfect, maybe in the future we can work on another backend.

@valeriocos valeriocos merged commit 2495f9f into chaoss:master Aug 9, 2019
valeriocos added a commit that referenced this pull request Aug 9, 2019
@valeriocos
Merge branch 'add_copyright_flag' of 'https://github.com/inishchith/g…
748a2e2 
…rimoirelab-graal'

Merges #50
Closes #49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valeriocos valeriocos valeriocos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[colic] Add copyright flag for extraction of copyright information
2 participants
@inishchith @valeriocos