Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add poetry support to SortingHat #602

Merged
merged 2 commits into from
Feb 24, 2022
Merged

Conversation

jjmerchante
Copy link
Contributor

@jjmerchante jjmerchante commented Feb 23, 2022

This PR:

  • Adds the files required to use Poetry for building and installing the package.
  • Moves the directories bin/ and misc/ inside SortingHat to be used in Poetry as scripts.
  • Changes setup.py to use the previous scripts as entry_points based on Perceval.

@jjmerchante jjmerchante force-pushed the support-poetry branch 2 times, most recently from d0b9596 to 6e340af Compare February 24, 2022 08:59
@vchrombie
Copy link
Member

The build is failing because of #603 and we have a PR to fix it #604

@sduenas
Copy link
Member

sduenas commented Feb 24, 2022

The build is failing because of #603 and we have a PR to fix it #604

I've just merged the PR. @vchrombie do you think this PR looks good?

This commit adds the support for sortinghat commands
to work as entrypoint. This is needed to make the
installation of Poetry.

Signed-off-by: Jose Javier Merchante <[email protected]>
Copy link
Member

@vchrombie vchrombie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had one minor comment, rest all looks good. I think we need to fix the build first before merging this.

cc @sduenas

pyproject.toml Show resolved Hide resolved
@vchrombie
Copy link
Member

I see the PR #604 is merged, it should fix the build failure 👍

This commit adds the files required to add Poetry
support to SortingHat. For installing and building
the package.

Signed-off-by: Jose Javier Merchante <[email protected]>
Copy link
Member

@vchrombie vchrombie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for working on this jj!

@sduenas sduenas closed this in 9eb0763 Feb 24, 2022
@sduenas sduenas merged commit 9eb0763 into chaoss:master Feb 24, 2022
@jjmerchante jjmerchante deleted the support-poetry branch March 22, 2022 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants