-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add poetry support to SortingHat #602
Conversation
d0b9596
to
6e340af
Compare
I've just merged the PR. @vchrombie do you think this PR looks good? |
This commit adds the support for sortinghat commands to work as entrypoint. This is needed to make the installation of Poetry. Signed-off-by: Jose Javier Merchante <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had one minor comment, rest all looks good. I think we need to fix the build first before merging this.
cc @sduenas
6e340af
to
725bdd7
Compare
I see the PR #604 is merged, it should fix the build failure 👍 |
This commit adds the files required to add Poetry support to SortingHat. For installing and building the package. Signed-off-by: Jose Javier Merchante <[email protected]>
725bdd7
to
f85de24
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for working on this jj!
This PR:
bin/
andmisc/
inside SortingHat to be used in Poetry as scripts.setup.py
to use the previous scripts as entry_points based on Perceval.