Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(makefile): support python 3.10 #18857

Merged
merged 1 commit into from
Dec 15, 2021
Merged

fix(makefile): support python 3.10 #18857

merged 1 commit into from
Dec 15, 2021

Conversation

branchvincent
Copy link
Contributor

This fixes a bug detecting the current Python version, noticed when building with Python 3.10 in Homebrew/homebrew-core#90708

Before:

$ make -C third-party/chpl-venv test-venv PYTHON=python3.10
python3 version 3.5 or later is required to install chpldoc and start_test dependencies. See https://www.python.org/

After:

$ make -C third-party/chpl-venv test-venv PYTHON=python3.10
...
Successfully installed ...

@bradcray
Copy link
Member

Pinging @mppf on this since it's his code that's changed and we tend not to be notified when new PRs are opened.

@mppf
Copy link
Member

mppf commented Dec 15, 2021

@branchvincent - thanks very much for this PR. It looks like a good fix to me. I'd just like to do a test run with it before merging.

@mppf
Copy link
Member

mppf commented Dec 15, 2021

I've verified make test-venv fails with the expected error with Python 3.4.6 but succeeds with Python 3.6.12. I also checked that the Python snippet being run works on Python 2.7. Besides that I will do our usual pre-merge testing.

@mppf
Copy link
Member

mppf commented Dec 15, 2021

Passes full local testing.

@mppf mppf merged commit 369954e into chapel-lang:main Dec 15, 2021
@bradcray
Copy link
Member

Thanks @branchvincent and @mppf!

@branchvincent
Copy link
Contributor Author

@bradcray @mppf thank you for the quick review/merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants