Allow installing pip dependencies from source #18926
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes changes that were in the Homebrew 1.25.1 release as patches to support building the Python pip dependencies from source.
--no-binary :all:
by first installing some chpldoc dependencies into the venv (since they are also build-time dependencies when building from source). Note that building the Python dependencies from source was suggested by Homebrew maintainers in chapel 1.25.1 Homebrew/homebrew-core#91257 (comment) . After this PR, the way to build the pip dependencies is by running e.g.make CHPL_PIP_FROM_SOURCE=1 test-venv
(vsCHPL_PIP_INSTALL_PARAMS=--no-binary :all:
which was used for the 1.25.1 Homebrew formula).Future work:
make CHPL_PIP_FROM_SOURCE=1 test-venv
functionsReviewed by @lydia-duncan - thanks!