Fix problem with ofi after PR #18880 #18971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to PR #18880 to fix a problem with ofi testing.
Even before PR #18880, we had
CHPL_COMM_OFI_OOBused in Makefiles and set by testingCHPL_RT_COMM_OFI_OOBthat was used in printchplenv before that PR and which I used afterPR #18880 added to the printchplenv logic and used it during
chplinvocations but that caused a problem becauseCHPL_COMM_OFI_OOBis set in testing (andCHPL_RT_COMM_OFI_OOBis not).This PR just changes the uses of
CHPL_RT_COMM_OFI_OOBin printchplenv toCHPL_COMM_OFI_OOBbecause it's used for computing-Iand-Lflags and these don't happen at runtime.Reviewed by @jhh67 - thanks!