-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the occurrence of module distutils
for Python 3.10
#19168
Remove the occurrence of module distutils
for Python 3.10
#19168
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all seems reasonable to me, I'll wait to run testing until you've resolved the merge conflicts (I think it's just a matter of accepting some additions from main to files you've modified)
Whoops, I missed that @lydia-duncan had already started a review on this (had a stale tab open from this morning.) I left some inline comments. I think the only one that is important to address is reverting the changes to third-party/llvm, the others are more style nits and I would be happy to follow up on those in a separate PR. |
…ailable Signed-off-by: Xuehai Pan <[email protected]>
…rsion` Signed-off-by: Xuehai Pan <[email protected]>
Signed-off-by: Xuehai Pan <[email protected]>
Signed-off-by: Xuehai Pan <[email protected]>
Signed-off-by: Xuehai Pan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Full std testing looks good:
[Summary: #Successes = 13581 | #Failures = 0 | #Futures = 0]
I think this is ready to merge, thanks @XuehaiPan!
@lydia-duncan any concerns?
No objections from me, thanks Elliot! |
Module
distutils
is deprecated in Python 3.10 and will be removed in Python 3.12.distutils
will no longer be a Python built-in module (standard library) and have been migrated tosetuptools
.See PEP 632 -- Deprecate
distutils
module.In this PR:
distutils.spawn.find_executable
→shutil.which
(python >= 3.2)distutils.version.LooseVersion
→pkg_resources.parse_version
(NOTE:pkg_resources
is part ofsetuptools
)distutils.core
→setuptools