Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the occurrence of module distutils for Python 3.10 #19168

Merged
merged 5 commits into from
Feb 4, 2022
Merged

Remove the occurrence of module distutils for Python 3.10 #19168

merged 5 commits into from
Feb 4, 2022

Conversation

XuehaiPan
Copy link
Contributor

@XuehaiPan XuehaiPan commented Feb 3, 2022

Module distutils is deprecated in Python 3.10 and will be removed in Python 3.12. distutils will no longer be a Python built-in module (standard library) and have been migrated to setuptools.

See PEP 632 -- Deprecate distutils module.

In this PR:

  1. distutils.spawn.find_executableshutil.which (python >= 3.2)
  2. distutils.version.LooseVersionpkg_resources.parse_version (NOTE: pkg_resources is part of setuptools)
  3. distutils.coresetuptools

Copy link
Member

@lydia-duncan lydia-duncan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all seems reasonable to me, I'll wait to run testing until you've resolved the merge conflicts (I think it's just a matter of accepting some additions from main to files you've modified)

@ronawho
Copy link
Contributor

ronawho commented Feb 4, 2022

Whoops, I missed that @lydia-duncan had already started a review on this (had a stale tab open from this morning.) I left some inline comments. I think the only one that is important to address is reverting the changes to third-party/llvm, the others are more style nits and I would be happy to follow up on those in a separate PR.

@XuehaiPan XuehaiPan requested a review from ronawho February 4, 2022 05:58
Copy link
Contributor

@ronawho ronawho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Full std testing looks good:

[Summary: #Successes = 13581 | #Failures = 0 | #Futures = 0]

I think this is ready to merge, thanks @XuehaiPan!

@lydia-duncan any concerns?

@lydia-duncan
Copy link
Member

No objections from me, thanks Elliot!

@ronawho ronawho merged commit 8656a41 into chapel-lang:main Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants