Fix problem with make install for AUR package #19846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Because `make install` always passes --stage= but it might be empty --- Signed-off-by: Michael Ferguson <[email protected]>
--- Signed-off-by: Michael Ferguson <[email protected]>
This logic originated in PR chapel-lang#15000 but was extended in a way that caused it to longer work since then with other PRs. --- Signed-off-by: Michael Ferguson <[email protected]>
ronawho
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes 3 improvements motivated by the effort to create an Arch Linux AUR package:
get_bundled_link_argsinutil/chplenv/third_party_utils.pyto fix a problem with falling back on a-lflag if the.lafile for the library is missing since the AUR install process removes the.lafiles. This fallback logic originated in Fall back to plain -lpkg, when third-party 'pkg.la' doesn't satisfy. #15000 but was disrupted by later changes to that function.chpl --print-chpl-settingsto print out all internal settings if--develis also passed (to make it easier to debug problems with chplenv scripts)install.shto only consider it a staged install if the stage directory is not the empty string (since the Makefile calling it always passes--stage=${DESTDIR}. As far as I know, this does not change the behavior of install.sh, but it fixes something that would probably be confusing if relied upon in more ways.Reviewed by @ronawho - thanks!