Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problems after LLVM configuration PRs #20439

Merged
merged 3 commits into from
Aug 12, 2022
Merged

Conversation

mppf
Copy link
Member

@mppf mppf commented Aug 12, 2022

Follow-up to PRs #20396 and #20385 to address issues raised by nightly testing.

  • build failures in cron-xc-wb-host-prgenv-cray-failure and xc-wb.prgenv-cray configurations: don't default to CHPL_LLVM_SUPPORT=system if all the LLVM dependencies are not installed. These configurations have just llvm-config but not the required headers.
  • networking-packages failure with curl tests: update common-quickstart.bash to set CHPL_LLVM=none. The quickstart setup script can provide CHPL_LLVM=none or CHPL_LLVM=system but since we test CHPL_LLVM=system in most configurations, in the quickstart testing configuration, we want to test CHPL_LLVM=none. At the moment, the curl tests do not all work with the LLVM backend.
  • darwin-m1 or other Mac OS testing failure with chpl-env-gen: fixed a sed portability issue between linux and Mac OS X.

Reviewed by @arezaii - thanks!

  • On Ubuntu, if llvm-14 is installed but not llvm-14-dev
    • default is CHPL_LLVM=unset and CHPL_LLVM_SUPPORT=bundled
    • setting CHPL_LLVM=system produces an error from printchplenv about a missing header
  • On Ubuntu, if we have the needed LLVM dependencies
    • default is CHPL_LLVM=system and CHPL_LLVM_SUPPORT=system
  • make functions on XC with PrgEnv-cray and GCC as the host compiler
  • make functions on XC with PrgEnv-cray and cray-prgenv-cray as the host compiler
  • full local testing

mppf added 3 commits August 12, 2022 11:30
Otherwise, we try to infer the default as CHPL_LLVM=system
when LLVM is not installed enough.

---
Signed-off-by: Michael Ferguson <[email protected]>
This makes the test configuration less dependent on the
environment (since quickstart will now use CHPL_LLVM=system
if that is available).

---
Signed-off-by: Michael Ferguson <[email protected]>
and improve errors in the test

---
Signed-off-by: Michael Ferguson <[email protected]>
@mppf mppf merged commit 6550afe into chapel-lang:main Aug 12, 2022
@mppf mppf deleted the fix-llvm-default branch August 12, 2022 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants