Bring in upstream gasnet patch for checking if LD requires MPI #20471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows a command like `pkg-config --variable=GASNET_PREFIX <pc-file>` to retrieve the base prefix of the GASNet installation. The variable value is empty in a build tree. Signed-off-by: Elliot Ronaghan <[email protected]>
New echovar(s)-preserve-unset targets work like echovar(s), but output nothing for variables that are unset, instead of an empty string. Signed-off-by: Elliot Ronaghan <[email protected]>
This change ensures that variables which are unset in the *.mak file that get exported to *.pc are also unset in the resulting *.pc. Signed-off-by: Elliot Ronaghan <[email protected]>
This propagates the following user-facing variables from the gasnet conduit-mode
*.mak fragments into the corresponding pkg-config *.pc file.
* GASNET_LD_REQUIRES_MPI
* GASNET_LD_REQUIRES_CXX
* GASNET_SPAWNER_DEFAULT
* GASNET_SPAWNER_PMI
* GASNET_SPAWNER_MPI
* GASNET_SPAWNER_SSH
The first was specifically requested by our Chapel stakeholder.
In all cases these exactly mirror the setness and values of the
corresponding *.mak variables.
In particular, `GASNET_LD_REQUIRES_{MPI,CXX}` are either 1 or unset,
just like the corresponding *.mak variables.
Similarly, `GASNET_SPAWNER_*` are unset for conduits where these
variables do not apply, just like the corresponding *.mak variables.
For conduits where they DO apply, GASNET_SPAWNER_{PMI,MPI,SSH} are
set to 1 (for supported) or 0 (for unsupported),
Signed-off-by: Elliot Ronaghan <[email protected]>
…MPI_CC Signed-off-by: Elliot Ronaghan <[email protected]>
Signed-off-by: Elliot Ronaghan <[email protected]>
Signed-off-by: Elliot Ronaghan <[email protected]>
mppf
approved these changes
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring in https://bitbucket.org/berkeleylab/gasnet/pull-requests/554 and
some related work to enable getting
GASNET_LD_REQUIRES_MPIout ofgasnet's pkg-config file. This is a follow up to #20385, which has
additional motivation for the change.