Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs related to build changes #20613

Merged
merged 5 commits into from
Sep 2, 2022
Merged

Conversation

mppf
Copy link
Member

@mppf mppf commented Sep 2, 2022

This PR includes docs updates related to PRs #19565 and #20396. This PR documents:

  • changes to how quickstart works
  • CHPL_LLVM_SUPPORT and the llvm support library being required.

While there, I:

  • adjusted prereqs.rst to only list the supported LLVM versions once and to say it is "LLVM and clang" that is needed
  • added sections in chplenv.rst for CHPL_LLVM_SUPPORT, CHPL_LLVM_CONFIG, and CHPL_LLVM_GCC_PREFIX

Reviewed by @lydia-duncan - thanks!

mppf added 3 commits September 2, 2022 13:59
---
Signed-off-by: Michael Ferguson <[email protected]>
---
Signed-off-by: Michael Ferguson <[email protected]>
and add documentation for CHPL_LLVM_SUPPORT

---
Signed-off-by: Michael Ferguson <[email protected]>
@lydia-duncan lydia-duncan self-requested a review September 2, 2022 18:26
Copy link
Member

@lydia-duncan lydia-duncan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of improvements, otherwise I think this is good to go!

---
Signed-off-by: Michael Ferguson <[email protected]>
---
Signed-off-by: Michael Ferguson <[email protected]>
@mppf mppf merged commit 57e73f1 into chapel-lang:main Sep 2, 2022
@mppf mppf deleted the docs-updates-building branch September 2, 2022 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants