Fix bare imports in AssetFinder subdirectories #924
Conversation
When creating a non-root AssetFinder, copy the parent's `extract_packages` so that importing bare modules works correctly. This is typically needed when packages are vendored and `sys.path` is dynamically updated to prefer the vendored version. Fixes: chaquo#820
|
This seems to be all that's needed. If the added test is run without copying the parent's |
|
Thanks, I'll have a look at this and your other PR in a few days. |
There was a problem hiding this comment.
Thanks very much for this, and sorry for taking so long to review it. The implementation change looks fine, but there was a problem with the test – it didn't reproduce the original problem, because murmurhash.about is a module, not a package. So I've changed it to use murmurhash.tests.
| # This is typically done when vendoring packages and dynamically adjusting sys.path. See #820. | ||
| def test_imp_subdir(self): | ||
| sys.modules.pop("about", None) | ||
| def test_path_subdir(self): |
There was a problem hiding this comment.
"imp" in the other tests refers to the imp module, which this isn't related to.
When creating a non-root AssetFinder, copy the parent's
extract_packagesso that importing bare modules works correctly. This is typically needed when packages are vendored andsys.pathis dynamically updated to prefer the vendored version.Fixes: #820