Fix enable_extension_features_if_present on Vulkan 1.0 #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/VkBootstrap.cpp
Outdated
| detail::vulkan_functions().fp_vkGetPhysicalDeviceFeatures2(physical_device, &actual_pdf2); | ||
| if (instance_version >= VKB_VK_API_VERSION_1_1) { | ||
| detail::vulkan_functions().fp_vkGetPhysicalDeviceFeatures2(physical_device, &actual_pdf2); | ||
| } else { |
There was a problem hiding this comment.
Suggested change
| } else { | |
| } else if (properties2_ext_enabled) { |
Good catch! However, to be even more correct the physical device properties 2 extension must be enabled.
There was a problem hiding this comment.
Apologies for the sloppiness! I think this iteration should be complete
csmartdalton
force-pushed
the
fix_1_0_extensions
branch
2 times, most recently
from
63c02d9 to
b6c011e
Compare
This method should call vkGetPhysicalDeviceFeatures2KHR on Vulkan 1.0.
csmartdalton
force-pushed
the
fix_1_0_extensions
branch
from
b6c011e to
2d417a2
Compare
charles-lunarg
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method should call vkGetPhysicalDeviceFeatures2KHR on Vulkan 1.0.