Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update dependency it.krzeminski:snakeyaml-engine-kmp to v3.1.1 #654

Merged
merged 1 commit into from
Feb 12, 2025
Merged

deps: update dependency it.krzeminski:snakeyaml-engine-kmp to v3.1.1 #654

merged 1 commit into from
Feb 12, 2025

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 3, 2025 •
edited
Loading

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
it.krzeminski:snakeyaml-engine-kmp 3.0.3 -> 3.1.1 age adoption passing confidence

Release Notes

krzema12/snakeyaml-engine-kmp (it.krzeminski:snakeyaml-engine-kmp)

v3.1.1: 3.1.1

Corresponds to snakeyaml-engine 2.9.

What's Changed

Customer-facing
Internal

Full Changelog: krzema12/snakeyaml-engine-kmp@v3.1.0...v3.1.1

v3.1.0: 3.1.0

Corresponds to snakeyaml-engine 2.8, with a few extra changes not released there yet.

What's Changed

Customer-facing
Internal

Full Changelog: krzema12/snakeyaml-engine-kmp@v3.0.3...v3.1.0

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot force-pushed the renovate/it.krzeminski-snakeyaml-engine-kmp-3.x branch from 58703fb to f957025 Compare January 3, 2025 09:32
@renovate renovate bot requested a review from charleskorn January 3, 2025 12:57
@renovate renovate bot force-pushed the renovate/it.krzeminski-snakeyaml-engine-kmp-3.x branch 3 times, most recently from dfa1c1a to 4d93a83 Compare January 8, 2025 22:40
@renovate renovate bot force-pushed the renovate/it.krzeminski-snakeyaml-engine-kmp-3.x branch from 4d93a83 to ba2b300 Compare January 15, 2025 04:47
@renovate renovate bot force-pushed the renovate/it.krzeminski-snakeyaml-engine-kmp-3.x branch 8 times, most recently from 908fbf3 to 50c0eb3 Compare February 1, 2025 08:40
@krzema12
Copy link
Contributor

krzema12 commented Feb 1, 2025

I filed a bug for it: https://youtrack.jetbrains.com/issue/KT-74871/NoSuchFileException-default-targets-linuxx64-kotlin

@renovate renovate bot force-pushed the renovate/it.krzeminski-snakeyaml-engine-kmp-3.x branch 2 times, most recently from 1e53222 to ab85c28 Compare February 10, 2025 00:32
@krzema12
Copy link
Contributor

We need to fix our publishing logic in snakeyaml-engine-kmp, see https://youtrack.jetbrains.com/issue/KT-74871/KN-NoSuchFileException-default-targets-linuxx64-kotlin-with-snakeyaml-engine-kmp-3.1.0#focus=Comments-27-11510364.0-0. It will be faster this way, instead of waiting for the bug in Kotlin to be resolved

@krzema12
Copy link
Contributor

krzema12 commented Feb 11, 2025 •
edited
Loading

@aSemy I'm wondering if you have capacity to fix this issue in an elegant, Gradle-sque way, per the comment in the YouTrack ticket?

@aSemy
Copy link
Contributor

aSemy commented Feb 11, 2025

@aSemy I'm wondering if you have capacity to fix this issue in an elegant, Gradle-sque way, per the comment in the YouTrack ticket?

Just delete the includeEmptyDirs = false code :)

@krzema12 krzema12 mentioned this pull request Feb 11, 2025
Closed
@krzema12
Copy link
Contributor

@aSemy I'm wondering if you have capacity to fix this issue in an elegant, Gradle-sque way, per the comment in the YouTrack ticket?

Just delete the includeEmptyDirs = false code :)

Ok, I'm just not aware of what can break by this change (I assume includeEmptyDirs = false is there for a reason), but let's try! Tracking in krzema12/snakeyaml-engine-kmp#405.

@krzema12
Copy link
Contributor

Released snakeyaml-engine-kmp 3.1.1 with a fix for this issue.

@renovate renovate bot force-pushed the renovate/it.krzeminski-snakeyaml-engine-kmp-3.x branch from ab85c28 to aa951c6 Compare February 11, 2025 23:32
@renovate renovate bot changed the title deps: update dependency it.krzeminski:snakeyaml-engine-kmp to v3.1.0 deps: update dependency it.krzeminski:snakeyaml-engine-kmp to v3.1.1 Feb 11, 2025
@renovate renovate bot merged commit 25bd52a into main Feb 12, 2025
12 checks passed
@renovate renovate bot deleted the renovate/it.krzeminski-snakeyaml-engine-kmp-3.x branch February 12, 2025 02:47
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 0.72.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aSemy
Copy link
Contributor

aSemy commented Feb 12, 2025

@aSemy I'm wondering if you have capacity to fix this issue in an elegant, Gradle-sque way, per the comment in the YouTrack ticket?

Just delete the includeEmptyDirs = false code :)

Ok, I'm just not aware of what can break by this change (I assume includeEmptyDirs = false is there for a reason), but let's try! Tracking in krzema12/snakeyaml-engine-kmp#405.

Basically, I added it because usually directories aren't important (it's unusual that they are for KMP), and usually Copy tasks just move files from one directory to another.

For example, if a foo.zip file contains foo/a/b/c/data.txt and you only want the data.txt file, then you can configure the Gradle unzip task to only select txt files, but then you're left with an empty foo/a/b/c/ directory.

It's also unusual that KGP didn't have a custom task for unzipping the files, and just used a Zip task (for plugin development it often pays off to be defensive and create your own tasks to avoid misconfiguration like this!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charleskorn charleskorn Awaiting requested review from charleskorn

Assignees
No one assigned
Labels
is:dependency-update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krzema12 @aSemy