Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add htmlAttributes to UmbracoRichText and upgrade to Vitest 2 #6

Merged
merged 8 commits into from
Jul 15, 2024

Conversation

thebuilder
Copy link
Contributor

@thebuilder thebuilder commented Jul 11, 2024

  • Adds support for setting default attributes that are forwarded to specific HTML elements, based on tag.
    • The className will be merged instead of overwritten.
  • Upgrade the project to Vitest 2, and use browser mode for tests
  • Use pnpm workspace, to avoid pnpm complaining about the examples projects.

The StackBlitz project is broken because of this change. Doesn't seem to start correctly with pnpm.
But if we don't run everything as workspace, the version for the example package is also going to be locked.

@thebuilder thebuilder requested a review from fbosch July 11, 2024 14:42
@thebuilder thebuilder changed the title Add htmlAttributes to UmbracoRichText and upgrade to Vite 2 Add htmlAttributes to UmbracoRichText and upgrade to Vitest 2 Jul 14, 2024
@thebuilder thebuilder merged commit bc825ed into main Jul 15, 2024
1 check passed
@thebuilder thebuilder deleted the feat/upgrade-vitest-2 branch July 15, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants