(v2) textarea,cursor: wrap up real cursor API #718
+290
−138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meowgorithm
force-pushed
the
v2-textarea-api
branch
from
54df5e8 to
f12acc3
Compare
aymanbagabas
approved these changes
Jan 28, 2025
meowgorithm
force-pushed
the
v2-textarea-api
branch
from
6f8ec71 to
e506cad
Compare
aymanbagabas
approved these changes
Jan 29, 2025
meowgorithm
force-pushed
the
v2-textarea-api
branch
2 times, most recently
from
9ad1ec1 to
eaf8725
Compare
Co-authored-by: Ayman Bagabas <[email protected]>
Co-authored-by: Ayman Bagabas <[email protected]>
Set.CursorColumn sets the cursor column position. This change was made for clarity.
meowgorithm
force-pushed
the
v2-textarea-api
branch
from
eaf8725 to
8c601be
Compare
meowgorithm
force-pushed
the
v2-textarea-api
branch
from
8c601be to
02ecc79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This revision adds the missing pieces necessary for
textareato support a real cursor. Additionally,Model.TextStylein thecursorpackage was renamed toModel.BlinkedStylefor clarity.