fix(filter): properly handle options with ansi styles #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome. I'm having a hard time reproducing this one. What am I doing wrong? printf "\x1b[38;5;212;48;5;63mOption 1,Option 2,Option3\x1b[m" | go run . filter --input-delimiter="," --height="10" |
|
missing see #785 for a reproducible |
caarlos0
added a commit
to charmbracelet/lipgloss
that referenced
this pull request
Jan 7, 2025
Extracted from charmbracelet/gum#789 , this allows to style ranges of a given string without breaking its current styles. The resulting ansi sequences aren't that beautiful (as there might be many styles+reset with nothing in them), but it works. We can optimize this later I think.
caarlos0
added a commit
to charmbracelet/lipgloss
that referenced
this pull request
Jan 7, 2025
Extracted from charmbracelet/gum#789 , this allows to style ranges of a given string without breaking its current styles. The resulting ansi sequences aren't that beautiful (as there might be many styles+reset with nothing in them), but it works. We can optimize this later I think.
|
Nice, I see it now. So in that case can we start and stop sequences at the delimiter with the great new Untitled.mov |
caarlos0
added a commit
to charmbracelet/lipgloss
that referenced
this pull request
Jan 9, 2025
* feat: style ranges Extracted from charmbracelet/gum#789 , this allows to style ranges of a given string without breaking its current styles. The resulting ansi sequences aren't that beautiful (as there might be many styles+reset with nothing in them), but it works. We can optimize this later I think. * fix: wide characters * feat: helper to style a single range * chore: review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #785
ansi.Truncate/ansi.TruncateLeftto avoid breaking stylessome screenshots: