Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs!: add additional info on Width behaviour #450

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Conversation

bashbunni
Copy link
Member

closes #298

@bashbunni bashbunni added the documentation Improvements or additions to documentation label Dec 2, 2024
@bashbunni
Copy link
Member Author

bashbunni commented Dec 3, 2024

Note: this is the desired behaviour for Width, but not accurate in its current implementation. The changes proposed in #451 would make this true, but will break existing layouts 🤔

edit: drafted so it won't be merged until we figure this out

@bashbunni bashbunni marked this pull request as draft December 3, 2024 19:18
@bashbunni bashbunni changed the title docs: add additional info on Width behaviour docs!: add additional info on Width behaviour Dec 3, 2024
@bashbunni bashbunni added the v2 label Dec 3, 2024
@bashbunni bashbunni changed the base branch from master to v2-exp January 8, 2025 15:21
@bashbunni bashbunni marked this pull request as ready for review January 8, 2025 15:21
@bashbunni bashbunni merged commit e163276 into v2-exp Jan 9, 2025
19 checks passed
@bashbunni bashbunni deleted the docs-width branch January 9, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Style.Width() and Style.GetHorizontalFrameSize() both include padding
2 participants