Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow special and lower-cased characters #23

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

raphamorim
Copy link
Member

@raphamorim raphamorim commented Feb 5, 2025

Special Characters

This PR fixes:

cat > vhs.tape
Ctrl+\

vhs vhs.tape
File: vhs.tape
  1 │ Ctrl+\
          ^ Not a valid modifier

  1 │ Ctrl+\
          ^ Invalid control argument: +

  1 │ Ctrl+\
           ^ Expected control character with args, got \

parser: 3 error(s)
recording failed

Lower-cased Characters

This allow VHS to support/highlight lowercased characters on Ctrl/Alt/Shift

====
Case sensitive on Ctrl/Alt/Shift
====

Ctrl+A
Ctrl+a
Alt+B
Alt+b
Shift+C
Shift+c

---

(program
 (command (control))
 (command (control))
 (command (alt))
 (command (alt))
 (command (shift))
 (command (shift)))

Nowadays we treat it on VHS and it does work with lower-cased however the syntax doesn't match

Copy link
Member

@caarlos0 caarlos0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but will need changes in vhs as well

.gitignore Outdated
tree-sitter.json
tree-sitter-vhs.pc
libtree-sitter-vhs.dylib
libtree-sitter-vhs.a
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing final line break.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh actually that was made by editorconfig plugin, is the rule without or with linebreak @caarlos0 @aymanbagabas @bashbunni ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh actually that was made by editorconfig plugin,

that's using the root editorconfig

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants