feat(term): ansi: move Wrap to Hardwrap and introduce Wrap #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aymanbagabas
force-pushed
the
smart-wrap
branch
2 times, most recently
from
2441682 to
6b796dc
Compare
aymanbagabas
added a commit
to charmbracelet/lipgloss
that referenced
this pull request
Mar 28, 2024
Uses `ansi.SmartWrap` charmbracelet/x#57 Fixes: muesli/reflow#43
aymanbagabas
force-pushed
the
smart-wrap
branch
from
6b796dc to
328355a
Compare
aymanbagabas
added a commit
to charmbracelet/lipgloss
that referenced
this pull request
Mar 28, 2024
Uses `ansi.SmartWrap` charmbracelet/x#57 Fixes: muesli/reflow#43
aymanbagabas
force-pushed
the
smart-wrap
branch
from
328355a to
9edb120
Compare
ANSI aware text wrapping that breaks word boundaries only when necessary. Fixes: charmbracelet/lipgloss#275 Fixes: muesli/reflow#43
aymanbagabas
force-pushed
the
smart-wrap
branch
from
9edb120 to
60946e0
Compare
aymanbagabas
added a commit
to charmbracelet/lipgloss
that referenced
this pull request
Mar 28, 2024
Uses `ansi.SmartWrap` charmbracelet/x#57 Fixes: muesli/reflow#43
aymanbagabas
commented
Mar 28, 2024
exp/term/ansi/wrap.go
Outdated
| // account for wide-characters in the string. The breakpoints string is a list | ||
| // of characters that are considered breakpoints for word wrapping. A hyphen | ||
| // (-) is always considered a breakpoint. | ||
| func SmartWrap(s string, limit int, breakpoints string) string { |
There was a problem hiding this comment.
Maybe SmartWrap is incorrect since there's a smarter way to wrap the text with less word breakage. Perhaps Wrap should be Hardwrap and this becomes just Wrap.
caarlos0
approved these changes
Mar 28, 2024
aymanbagabas
added a commit
to charmbracelet/lipgloss
that referenced
this pull request
Mar 28, 2024
Uses `ansi.SmartWrap` charmbracelet/x#57 Fixes: muesli/reflow#43
aymanbagabas
changed the title
meowgorithm
approved these changes
Mar 29, 2024
aymanbagabas
added a commit
to charmbracelet/lipgloss
that referenced
this pull request
Mar 29, 2024
* feat: switch to term/ansi for text manipulation Use ANSI aware, wide characters support, uniseg backed term/ansi package to calculate string widths, truncate, and wrap strings. Related: muesli/reflow#71 Fixes: #258 Fixes: #220 * fix: combining both conditional and unconditional wrapping Uses `ansi.SmartWrap` charmbracelet/x#57 Fixes: muesli/reflow#43 * chore: update deps * Update get.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ANSI aware text wrapping that breaks word boundaries only when necessary.
Fixes: charmbracelet/lipgloss#275
Fixes: muesli/reflow#43