Remove unnecessary checks for hidden data #6255
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It comes from #2346. |
|
I would be surprised if it broke any tests since the controllers don't use the |
simonbrunel
requested changes
May 8, 2019
There was a problem hiding this comment.
Element supports the hidden state (public) and controllers should handle it since it can be altered by external code (custom legend, plugins, etc.). This PR would likely break a few integrations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hiding of an individual data item is undocumented and no controller using these scales actually supports it.
This leaves support for
hiddenfor the polarArea and doughnut controllers and radialLinear scale