-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add babel plugin for rollup & transform code #6555
Conversation
@etimberg I don't have any major objections to this since we already need to compile the code to run it, but I know that @simonbrunel had wanted to wait until v3. See #5787 (comment) |
Perhaps we should leave this until after 2.9 and then make the next version v3? Seems like we've got a long list of stuff to do |
Very much in favor of adding babel. There should be no reason we could not enable it now. It should not break anything. If things need no transpiling, it should be a noop. |
@benmccann now that v2.9 is out, shall we merge this? |
I think using a "defaults" is defined as: https://github.com/browserslist/browserslist/blob/2fee1e4d7b1bae0214bbbef10d04087a2785dfd3/index.js#L429 |
bf26a54
to
93d730a
Compare
@benmccann I added the |
Adds the babel rollup plugin to enable moving the codebase to ES6+.
I did not configure the preset targets yet. We can do that once we decide what exactly we want to support.