Finishing removing old major/minor options #7042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etimberg
reviewed
Jan 31, 2020
benmccann
force-pushed
the
scriptable-tick-cleanup
branch
from
21755b2 to
1904b79
Compare
|
Yeah, it should be in the migration guide already |
etimberg
previously approved these changes
Jan 31, 2020
|
Yep! That'd be the way to do it. The financial sample does that: https://www.chartjs.org/samples/master/advanced/financial.html |
|
Ah, perfect! |
|
Could fix the samples using |
|
Yeah, good idea. I just copied your changes from #7020 for those two files |
kurkle
reviewed
Jan 31, 2020
There was a problem hiding this comment.
Should probably make to major a boolean instead of object, since it only accepts enabled property now.
Just a personal note about scriptable options: I find those handy at times, but also cumbersome for really simple tasks (like font styling). IMO it should not be the only option.
|
This one needs a rebase, I think its good to go after that. |
benmccann
force-pushed
the
scriptable-tick-cleanup
branch
from
8f7d8c7 to
674536e
Compare
benmccann
force-pushed
the
scriptable-tick-cleanup
branch
from
674536e to
2bbdac6
Compare
benmccann
force-pushed
the
scriptable-tick-cleanup
branch
from
2bbdac6 to
b6200a3
Compare
etimberg
approved these changes
Feb 4, 2020
kurkle
approved these changes
Feb 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6939 removed the concept of different formatting for major and minor ticks and replaced it with scriptable tick options. I found a place where I forgot to remove the old options
ticks.callbackalready has a test, so I was able to just remove the old tests and didn't have to add or update any