Remove use of helpers for v3 compatibility #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurkle
approved these changes
Jul 20, 2020
etimberg
approved these changes
Jul 20, 2020
|
Can you publish a new release with these changes? |
|
I sent #21 to do a new release |
etimberg
pushed a commit
that referenced
this pull request
Aug 17, 2020
* Update rollup and add ESM output (#17) Update rollup and add ESM output * Update README with latest version (#15) * Remove bower (#19) * Remove use of helpers for v3 compatibility (#20) * Fix startOf function for isoWeek (#23) Fix startOf function for isoWeek * Bump version to 0.2.2 (#21) Co-authored-by: Colin Griffin <[email protected]> Co-authored-by: stockiNail <[email protected]>
Merged
etimberg
pushed a commit
that referenced
this pull request
Aug 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will let us keep using the same version for v2 and v3. With the recent changes to support tree-shaking if we import the helpers in a v3-compatible way then we will lose v2 compatibility