Support hover events #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compwright
force-pushed
the
feature-annotation-events
branch
from
2f0f9cc to
39dfe70
Compare
Also fixes a click event duplication when a dblclick event happens
compwright
force-pushed
the
feature-annotation-events
branch
from
39dfe70 to
816d253
Compare
etimberg
approved these changes
Dec 1, 2016
| @@ -124,6 +123,12 @@ Vertical or horizontal lines are supported. | |||
|
|
|||
| // Mouse event handlers - be sure to enable the corresponding events in the | |||
| // annotation events array or the event handler will not be called. | |||
| // See https://developer.mozilla.org/en-US/docs/Web/Events for a list of | |||
| // supported mouse events. | |||
| onMouseenter: function(e) {}, | |||
There was a problem hiding this comment.
Would it be a good idea to support touch events as well?
There was a problem hiding this comment.
Eventually, yes, but it will need some care to do it right in a way that works cross-browser and also works for the user. Probably need some hit radius logic added, and integration with Hammer.js. That's more than I can get into right now.
| } | ||
| } | ||
|
|
||
| // Suppress duplicate click events during a double click |
There was a problem hiding this comment.
I like this comment. Very detailed :)
compwright
added a commit
to compwright/chartjs-plugin-annotation
that referenced
this pull request
Dec 3, 2016
Includes chartjs#44, chartjs#45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes a click event duplication when a
dblclickevent happens.