Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sponsorship and claimable balance operations and effects #238

Closed
leighmcculloch opened this issue Mar 3, 2021 · 4 comments
Closed

Sponsorship and claimable balance operations and effects #238

leighmcculloch opened this issue Mar 3, 2021 · 4 comments
Assignees

Comments

@leighmcculloch
Copy link
Contributor

Issue Description

I've noticed when viewing accounts that have claimable balance operations, and sponsorship operations, that the generic 'unrecognized' operation text that was introduced in #198 gets displayed. I think this means the explorer doesn't currently have a definition for how to display these operations and so no meaningful information is being displayed.

The operations missing definitions appear to be:

  • create_claimable_balance
  • claim_claimable_balance
  • begin_sponsoring_future_reserves
  • end_sponsoring_future_reserves
  • revoke_sponsorship

The list of operations are here:
https://github.com/stellar/go/blob/5c62e03/protocols/horizon/operations/main.go#L31-L35

Example:
Screen Shot 2021-03-03 at 1 21 17 PM

Ref: https://steexp.com/account/GDTNXS4SNQFDXBVKOBU6QIAMAW6A3KV3VK4Z5RSDLAB7YXZSUIL2PU4X#operations

Similar with effects, there looks to be 18 effects missing definitions:

  • claimable_balance_created
  • claimable_balance_claimed
  • claimable_balance_claimant_created
  • account_sponsorship_created
  • account_sponsorship_updated
  • account_sponsorship_removed
  • trustline_sponsorship_created
  • trustline_sponsorship_updated
  • trustline_sponsorship_removed
  • data_sponsorship_created
  • data_sponsorship_updated
  • data_sponsorship_removed
  • claimable_balance_sponsorship_created
  • claimable_balance_sponsorship_updated
  • claimable_balance_sponsorship_removed
  • signer_sponsorship_created
  • signer_sponsorship_updated
  • signer_sponsorship_removed

The list of effects are here:
https://github.com/stellar/go/blob/5c62e03/protocols/horizon/effects/main.go#L207-L224

Example:
Screen Shot 2021-03-03 at 1 23 11 PM

Ref: https://steexp.com/account/GDTNXS4SNQFDXBVKOBU6QIAMAW6A3KV3VK4Z5RSDLAB7YXZSUIL2PU4X#effects

@leighmcculloch leighmcculloch changed the title Sponsorship and claimable balance operations Sponsorship and claimable balance operations and effects Mar 3, 2021
@chatch
Copy link
Owner

chatch commented Mar 5, 2021

Thank you @leighmcculloch . I'll look at adding support for these soon.

@chatch chatch self-assigned this Apr 25, 2021
@chatch chatch pinned this issue Apr 25, 2021
@Ahmadjakaria
Copy link

Semoga hadir nya Pi network ini
Bermanfaat bagi ekonomi global khusus nya di negara kami Indonesia

Aamiin... 🤲🤲🤲

@chatch chatch unpinned this issue Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants
@leighmcculloch @chatch @Ahmadjakaria and others