Fix number_of_selfloops() call for recent networkx versions #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The number_of_selfloops() graph method was deprecated in the networkx 2.0 release[1] which was released in 2017 and replaced with a function that provides the same functionality. In the recent 2.4 release this deprecated method has been removed. This commit updates the use of number_of_selfloops to use that function instead of the deprecated and now removed method. It also increases the minimum version supported by the library to use 2.0 which was the version this function was introduced. Fixes chebee7i#14 [1] https://networkx.github.io/documentation/stable/release/release_2.0.html#api-changes
mtreinish
added a commit
to mtreinish/qiskit-core
that referenced
this pull request
Oct 17, 2019
With the recent release of networkx 2.4 several deprecated APIs were removed. This broke the visualization dependency nxpd. A fix is in progress [1] to address this. But in the meantime to get tests working again we need to make sure we do not install networkx 2.4 for testing. This commit does this by pinning the version we use in our testing in the constraints file to 2.3. This will unblock our development while we wait for a new nxpd release. [1] chebee7i/nxpd#15
kdk
pushed a commit
to Qiskit/qiskit
that referenced
this pull request
Oct 17, 2019
With the recent release of networkx 2.4 several deprecated APIs were removed. This broke the visualization dependency nxpd. A fix is in progress [1] to address this. But in the meantime to get tests working again we need to make sure we do not install networkx 2.4 for testing. This commit does this by pinning the version we use in our testing in the constraints file to 2.3. This will unblock our development while we wait for a new nxpd release. [1] chebee7i/nxpd#15
mtreinish
added a commit
to mtreinish/qiskit-core
that referenced
this pull request
Oct 28, 2019
With the recent release of networkx 2.4 several deprecated APIs were removed. This broke the visualization dependency nxpd. A fix is in progress [1] to address this. But in the meantime to get tests working again we need to make sure we do not install networkx 2.4 for testing. This commit does this by pinning the version we use in our testing in the constraints file to 2.3. This will unblock our development while we wait for a new nxpd release. [1] chebee7i/nxpd#15 (cherry picked from commit 38b03f4)
kdk
pushed a commit
to Qiskit/qiskit
that referenced
this pull request
Oct 28, 2019
With the recent release of networkx 2.4 several deprecated APIs were removed. This broke the visualization dependency nxpd. A fix is in progress [1] to address this. But in the meantime to get tests working again we need to make sure we do not install networkx 2.4 for testing. This commit does this by pinning the version we use in our testing in the constraints file to 2.3. This will unblock our development while we wait for a new nxpd release. [1] chebee7i/nxpd#15 (cherry picked from commit 38b03f4)
faisaldebouni
pushed a commit
to faisaldebouni/qiskit-terra
that referenced
this pull request
Aug 5, 2020
With the recent release of networkx 2.4 several deprecated APIs were removed. This broke the visualization dependency nxpd. A fix is in progress [1] to address this. But in the meantime to get tests working again we need to make sure we do not install networkx 2.4 for testing. This commit does this by pinning the version we use in our testing in the constraints file to 2.3. This will unblock our development while we wait for a new nxpd release. [1] chebee7i/nxpd#15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The number_of_selfloops() graph method was deprecated in the networkx
2.0 release[1] which was released in 2017 and replaced with a
function that provides the same functionality. In the recent 2.4 release
this deprecated method has been removed. This commit updates the use of
number_of_selfloops to use that function instead of the deprecated and
now removed method. It also increases the minimum version supported by
the library to use 2.0 which was the version this function was
introduced.
Fixes #14
[1] https://networkx.github.io/documentation/stable/release/release_2.0.html#api-changes