fix: do hostname override in commands not in cli

integrations/action/action.yml

@@ -6,6 +6,7 @@ branding:
   color: 'orange'
 inputs:
   hostname:
+    default: api.check-run-reporter.com
     description: Internal. Do not use unless directed. Supercedes --url
     required: false
   label:

integrations/action/src/index.ts

@@ -88,6 +88,7 @@ export async function findReports(): Promise<string[]> {
 }
 
 interface DoSplitInput {
+  readonly hostname: string;
   readonly label: string;
   readonly tests: string;
   readonly token: string;
@@ -97,7 +98,7 @@ interface DoSplitInput {
 /**
  * Wrapper around split to adapt it for github actions
  */
-async function doSplit({label, tests, token, url}: DoSplitInput) {
+async function doSplit({hostname, label, tests, token, url}: DoSplitInput) {
   const nodeCount = core.getInput('nodeCount');
   const nodeIndex = core.getInput('nodeIndex');
 
@@ -112,6 +113,7 @@ async function doSplit({label, tests, token, url}: DoSplitInput) {
   try {
     const {filenames} = await split(
       {
+        hostname,
         label,
         nodeCount: Number(nodeCount),
         nodeIndex: Number(nodeIndex),
@@ -151,12 +153,14 @@ async function main() {
     core.getInput('label') ||
     `${github.context.workflow} / ${github.context.job}`;
 
+  const hostname = core.getInput('hostname');
   const token = core.getInput('token');
   const url = core.getInput('url');
 
   const tests = core.getInput('tests');
   if (tests) {
     return await doSplit({
+      hostname,
       label,
       tests,
       token,
@@ -171,6 +175,7 @@ async function main() {
 
   await submit(
     {
+      hostname,
       label,
       report: files,
       root,

src/cli.ts

@@ -59,15 +59,12 @@ export function cli(argv: string[]) {
               "Mostly here for future use, this let's us specify an alternate endpoint for testing new features. Unless specifically told to do so by support, please don't change this value.",
           },
         }),
-      async ({hostname, tests, url, ...args}) => {
+      async ({tests, ...args}) => {
         const directlyUseOutput = !process.stdout.isTTY;
 
-        const u = new URL(url);
-        u.hostname = hostname;
-
         try {
           const result = await split(
-            {...args, tests: tests.map(String), url: u.toString()},
+            {...args, tests: tests.map(String)},
             {logger: directlyUseOutput ? silentLogger : logger}
           );
           if (directlyUseOutput) {
@@ -136,14 +133,11 @@ export function cli(argv: string[]) {
               "Mostly here for future use, this let's us specify an alternate endpoint for testing new features. Unless specifically told to do so by support, please don't change this value.",
           },
         }),
-      async ({hostname, report, url, ...args}) => {
-        const u = new URL(url);
-        u.hostname = hostname;
+      async ({report, ...args}) => {
         return submit(
           {
             ...args,
             report: report.map(String),
-            url: u.toString(),
           },
           {logger}
         );

src/commands/split.spec.ts

@@ -42,6 +42,7 @@ describe('split()', () => {
 
     const result = await split(
       {
+        hostname: 'api.check-run-reporter.com',
         label: 'foo',
         nodeCount: 3,
         nodeIndex: 2,

src/commands/split.ts

@@ -7,6 +7,7 @@ import {multiGlob} from '../lib/file';
 import {Context} from '../lib/types';
 
 interface SplitArgs {
+  readonly hostname: string;
   /** list of filenames or globs that match all available test files */
   readonly tests: readonly string[];
   readonly label: string;
@@ -21,9 +22,19 @@ interface SplitArgs {
  * appropriate to this node.
  */
 export async function split(
-  {tests, label, nodeCount, nodeIndex, token, url}: SplitArgs,
+  {hostname, tests, label, nodeCount, nodeIndex, token, url}: SplitArgs,
   context: Context
 ) {
+  const u = new URL(url);
+  if (hostname !== u.hostname) {
+    u.hostname = hostname;
+    context.logger.info('Overriding hostname', {
+      newUrl: u.href,
+      originalUrl: url,
+    });
+    url = u.href;
+  }
+
   // This is just here to test the buildkite plugin. The only other option I can
   // think of is to run a server locally that responds with this and use the
   // `url` param, but that currently seems like more trouble than its worth for

src/commands/submit.spec.ts

@@ -37,6 +37,7 @@ describe('submit()', () => {
 
     await submit(
       {
+        hostname: 'api.check-run-reporter.com',
         label: 'foo',
         report: ['reports/junit/**/*.xml'],
         root: '/',
@@ -59,6 +60,7 @@ describe('submit()', () => {
 
     await submit(
       {
+        hostname: 'api.check-run-reporter.com',
         label: 'foo',
         report: ['reports/junit/**/*.xml'],
         root: '/',

src/commands/submit.ts

@@ -8,6 +8,7 @@ import {multiStepUpload, singleStepUpload} from '../lib/upload';
 import {getRequestId} from '../lib/axios';
 
 interface SubmitArgs {
+  readonly hostname: string;
   readonly label: Optional<string>;
   readonly report: readonly string[];
   readonly root: string;
@@ -55,9 +56,20 @@ export async function submit(input: SubmitArgs, context: Context) {
  * efficient once the new version is released.
  */
 async function tryMultiStepUploadOrFallbackToSingle(
-  input: SubmitArgs,
+  {hostname, url, ...rest}: SubmitArgs,
   context: Context
 ) {
+  const u = new URL(url);
+  if (hostname !== u.hostname) {
+    u.hostname = hostname;
+    context.logger.info('Overriding hostname', {
+      newUrl: u.href,
+      originalUrl: url,
+    });
+    url = u.href;
+  }
+  const input = {url, ...rest};
+
   try {
     return await multiStepUpload(input, context);
   } catch (err) {