Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #16242: added xml plugin and fixing google-style links #16267

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Broilzzz
Copy link
Contributor

@Broilzzz Broilzzz commented Feb 1, 2025

Issue #16242

Not completed, just testing out the links output

@Broilzzz
Copy link
Contributor Author

Broilzzz commented Feb 1, 2025

GitHub, generate website

@romani
Copy link
Member

romani commented Feb 1, 2025

you do not need CI to test, you can do on local https://github.com/checkstyle/checkstyle/wiki/How-to-run-certain-phases-and-validations#how-to-generate-website-only

please play and experiment on local.

Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

items:

pom.xml Outdated
@@ -521,6 +521,12 @@
<artifactId>maven-shade-plugin</artifactId>
<version>3.6.0</version>
</plugin>
<!-- https://mvnrepository.com/artifact/org.codehaus.mojo/xml-maven-plugin -->
<plugin>
<groupId>org.codehaus.mojo</groupId>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please move to separate PR such update
and you actually need to remove follwing two lines:

 <!-- until #16077 -->
          <skip>true</skip>

@Broilzzz
Copy link
Contributor Author

Broilzzz commented Feb 1, 2025

fix links in sun and Google style, remove them from suppression that we did in first PR

im confused as to where do each of them points to, or do they point to a common location?

@romani
Copy link
Member

romani commented Feb 1, 2025

location of suppression https://github.com/checkstyle/checkstyle/pull/16126/files#diff-8ebc4a79e7f2d18e09357cee57041175c404c841fe4c1cf970a9b6421b710e2cR1359 , please remove it, so you will see violation.

after that run ./.ci/run-link-check-plugin.sh --skip-external on local to see what plugin is violating.

if links are good, we probably need to find why maven plugin thinks them are bad.

@Broilzzz
Copy link
Contributor Author

Broilzzz commented Feb 4, 2025

not completed, just checking if direction is correct.

Did the changes as per request,
encountered this error
org.apache.maven.project.ProjectBuildingException: Error resolving project artifact: The following artifacts could not be resolved: org.eclipse.m2e:lifecycle-mapping:pom:1.0.0 (absent): org.eclipse.m2e:lifecycle-mapping:pom:1.0.0 was not found in https://repo.maven.apache.org/maven2 during a previous attempt. This failure was cached in the local repository and resolution is not reattempted until the update interval of central has elapsed or updates are forced for project org.eclipse.m2e:lifecycle-mapping:pom:1.0.0

on researching found that creating a profile for it mitigates the error
reference: https://stackoverflow.com/questions/7905501/get-rid-of-pom-not-found-warning-for-org-eclipse-m2elifecycle-mapping

now currently fixing this error
[INFO] ------------------------------------------------------------------------ [ERROR] Failed to execute goal org.codehaus.mojo:xml-maven-plugin:1.1.0:validate (default) on project checkstyle: While parsing C:\Users\AHIL\contri\checkstyle\src\site\site.xml, at file:/C:/Users/AHIL/contri/checkstyle/src/site/site.xml, line 6, column 72: error: cvc-elt.1.a: Cannot find the declaration of element 'site'.

@Broilzzz
Copy link
Contributor Author

Broilzzz commented Feb 4, 2025

location of suppression https://github.com/checkstyle/checkstyle/pull/16126/files#diff-8ebc4a79e7f2d18e09357cee57041175c404c841fe4c1cf970a9b6421b710e2cR1359 , please remove it, so you will see violation.

after that run ./.ci/run-link-check-plugin.sh --skip-external on local to see what plugin is violating.

if links are good, we probably need to find why maven plugin thinks them are bad.

do i remove only the google_style and sun_style supressions?

@romani
Copy link
Member

romani commented Feb 4, 2025

Let's first remove only google_style

@Broilzzz
Copy link
Contributor Author

Broilzzz commented Feb 6, 2025

Let's first remove only google_style

on it

@romani
Copy link
Member

romani commented Feb 18, 2025

@Broilzzz, ping .

1 similar comment
@romani
Copy link
Member

romani commented Mar 4, 2025

@Broilzzz, ping .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants