-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #16242: added xml plugin and fixing google-style links #16267
base: master
Are you sure you want to change the base?
Conversation
GitHub, generate website |
you do not need CI to test, you can do on local https://github.com/checkstyle/checkstyle/wiki/How-to-run-certain-phases-and-validations#how-to-generate-website-only please play and experiment on local. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
items:
pom.xml
Outdated
@@ -521,6 +521,12 @@ | |||
<artifactId>maven-shade-plugin</artifactId> | |||
<version>3.6.0</version> | |||
</plugin> | |||
<!-- https://mvnrepository.com/artifact/org.codehaus.mojo/xml-maven-plugin --> | |||
<plugin> | |||
<groupId>org.codehaus.mojo</groupId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please move to separate PR such update
and you actually need to remove follwing two lines:
<!-- until #16077 -->
<skip>true</skip>
im confused as to where do each of them points to, or do they point to a common location? |
location of suppression https://github.com/checkstyle/checkstyle/pull/16126/files#diff-8ebc4a79e7f2d18e09357cee57041175c404c841fe4c1cf970a9b6421b710e2cR1359 , please remove it, so you will see violation. after that run if links are good, we probably need to find why maven plugin thinks them are bad. |
0429d40
to
fcf5301
Compare
not completed, just checking if direction is correct. Did the changes as per request, on researching found that creating a profile for it mitigates the error now currently fixing this error |
do i remove only the google_style and sun_style supressions? |
Let's first remove only google_style |
on it |
@Broilzzz, ping . |
1 similar comment
@Broilzzz, ping . |
Issue #16242
Not completed, just testing out the links output