Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 15770: Github Remainder Bot #16394

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

roulpriya
Copy link
Contributor

@roulpriya roulpriya commented Feb 22, 2025

Fixes Issue: #15770

https://github.com/actions/stale

we can handle PRs with different settings , or skip them at all: https://github.com/actions/stale?tab=readme-ov-file#days-before-close

This workflow implements an automated remainder using GitHub Actions.

Workflow Name: feedback-reminder-bot
Trigger: Runs automatically every day at midnight UTC using a cron schedule
Permissions: Has read access to repository contents and write access to issues
The workflow uses the official GitHub actions/stale@v9 action to manage inactive issues.

Functionality:
Target issues labelled with awaiting-response
After 7 days of inactivity, add a friendly reminder message requesting feedback
If there is no response within another 7 days, close the issue with a no-response label

so it can close: https://github.com/checkstyle/checkstyle/issues?q=is%3Aissue%20state%3Aopen%20label%3A%22awaiting%20response%22
are we ok with this ?

@romani
Copy link
Member

romani commented Feb 22, 2025

#8312 is just miss on our side, but reminder bot will make comment on it, so we will be able to remove annotation at least, or ask to update issue description.

is good for pinning of user:
#15840
#10356
#6638

good part that comment is reminder for maintainers too. Even issue closure will be notisable in notificatons, so maintainer can always reopen to give issue a bit more time.

@romani
Copy link
Member

romani commented Feb 22, 2025

@rdiachenko , @nrmancuso , @mahfouz72 , please share your ideas on what policies we should use for issues and PRs.

@rnveach
Copy link
Member

rnveach commented Feb 22, 2025

So I don't get a say here?

@roulpriya roulpriya force-pushed the github-remainder-bot branch from 320039b to 891f3d0 Compare February 24, 2025 18:22
@romani
Copy link
Member

romani commented Feb 24, 2025

Ok, let's proceed with following parameters:
For PRs: two labels to select , awaiting-*, remember each 15 days, closing after 60 Days.

Same for issues.

Life usage will show what are better parameters, periods. We start with basic.

@nrmancuso
Copy link
Member

Ok, let's proceed with following parameters: For PRs: two labels to select , awaiting-*, remember each 15 days, closing after 60 Days.

Same for issues.

Life usage will show what are better parameters, periods. We start with basic.

I am good with this

@rnveach
Copy link
Member

rnveach commented Feb 25, 2025

I feel my comment is being ignored.

@roulpriya roulpriya force-pushed the github-remainder-bot branch 4 times, most recently from 16ccacc to 040bb20 Compare March 4, 2025 18:26
@roulpriya roulpriya marked this pull request as ready for review March 4, 2025 18:26
Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reordering, some parameters are removed.

uses: actions/stale@v9
with:
stale-issue-message: |
Hello 👋!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jobs:
  close-inactive-issues:
    runs-on: ubuntu-latest
    steps:
      - name: check and close inactive issues and PRs
        uses: actions/stale@v9
        with:
          any-of-labels: "awaiting response,awaiting changes"

          days-before-stale: 15
          stale-issue-label: "response requested"
          stale-pr-label: "response requested"
          stale-issue-message: |
            Hello 👋!

            It looks like this issue has been inactive for a while.
            Could you provide the requested feedback?
            If no response is received in the next 15 days, we will close this issue.
          stale-pr-message: |
            Hello 👋!

            It looks like this pull request has been inactive for a while.
            Could you provide the requested feedback?
            If no response is received in the next 15 days, we will close this pull request.
          
          days-before-close: 60
          close-issue-message: |
            Hello 👋!

            Since we haven't received any feedback, we are closing this issue.
            If you have any questions or need further assistance,
            please feel free to reopen this issue.
          close-pr-message: |
            Hello 👋!

            Since we haven't received any feedback, we are closing this pull request.
            If you have any questions or need further assistance,
            please feel free to reopen this pull request.

@roulpriya roulpriya force-pushed the github-remainder-bot branch from 040bb20 to 9efae67 Compare March 5, 2025 18:00
Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try this action

@romani romani requested a review from nrmancuso March 5, 2025 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants